Move heap numbers directly to VFP3 registers in comparison stub.

Move heap numbers directly to VFP3 registers in comparison stub.

Committed: http://code.google.com/p/v8/source/detail?r=3715

[William Hesse, 2010-01-26 15:22:29]

Includes creation of boolean variable use_fp_registers.

[Erik Corry, 2010-01-26 16:23:59]

LGTM

http://codereview.chromium.org/556020/diff/1001/1002
File src/arm/codegen-arm.cc (right):

http://codereview.chromium.org/556020/diff/1001/1002#newcode4867
src/arm/codegen-arm.cc:4867: __ push(lr);
You can move this push(lr) and the corresponding pop(lr) into the if since it is
only necessary when there is a call.  Similarly below.

http://codereview.chromium.org/556020/diff/1001/1002#newcode4915
src/arm/codegen-arm.cc:4915: // Load the double from lhs, tagged HeapNumber r1,
to d7.
You should do this first since the vldr has a delay that you can use to do the
other instructions.

http://codereview.chromium.org/556020/diff/1001/1002#newcode5153
src/arm/codegen-arm.cc:5153: // __ vmov(d6, r0, r1);
Commented out code.

[William Hesse, 2010-01-27 10:04:47]

Changes made.

http://codereview.chromium.org/556020/diff/1001/1002
File src/arm/codegen-arm.cc (right):

http://codereview.chromium.org/556020/diff/1001/1002#newcode4867
src/arm/codegen-arm.cc:4867: __ push(lr);
On 2010/01/26 16:24:00, Erik Corry wrote:
> You can move this push(lr) and the corresponding pop(lr) into the if since it
is
> only necessary when there is a call.  Similarly below.

Done.

http://codereview.chromium.org/556020/diff/1001/1002#newcode4915
src/arm/codegen-arm.cc:4915: // Load the double from lhs, tagged HeapNumber r1,
to d7.
On 2010/01/26 16:24:00, Erik Corry wrote:
> You should do this first since the vldr has a delay that you can use to do the
> other instructions.

Done.

http://codereview.chromium.org/556020/diff/1001/1002#newcode4924
src/arm/codegen-arm.cc:4924: ConvertToDoubleStub stub2(r0, r1, r7, r6);
Operands swapped - why didn't this cause failures?

http://codereview.chromium.org/556020/diff/1001/1002#newcode5153
src/arm/codegen-arm.cc:5153: // __ vmov(d6, r0, r1);
On 2010/01/26 16:24:00, Erik Corry wrote:
> Commented out code.

Done.