Issue 556003: (Second attempt at http://codereview.chromium.org/553069/show)...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 556003: (Second attempt at http://codereview.chromium.org/553069/show)... (Closed)

Created:
10 years, 11 months ago by joth

Modified:
9 years, 7 months ago

Reviewers:
jorlow

CC:
chromium-reviews, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

(Second attempt at http://codereview.chromium.org/553069/show -- this time including DEPS exclusion) These files are lifted from gears: http://code.google.com/p/gears/source/browse/trunk/gears/geolocation/ NOTE this is a direct copy of gears files; subsequent edits will be made to bring them into chrome style and add to gypi files and so on. BUG=11246 TEST=None (just adding placeholder files; tests will follow in next change) Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=37117

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1940 lines, -0 lines)			Patch
M	chrome/browser/DEPS	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download
A	chrome/browser/geolocation/device_data_provider.h	View		1 chunk	+391 lines, -0 lines	0 comments	Download
A	chrome/browser/geolocation/empty_device_data_provider.h	View		1 chunk	+51 lines, -0 lines	0 comments	Download
A	chrome/browser/geolocation/empty_device_data_provider.cc	View		1 chunk	+39 lines, -0 lines	0 comments	Download
A	chrome/browser/geolocation/wifi_data_provider_common.h	View		1 chunk	+39 lines, -0 lines	0 comments	Download
A	chrome/browser/geolocation/wifi_data_provider_common.cc	View		1 chunk	+95 lines, -0 lines	0 comments	Download
A	chrome/browser/geolocation/wifi_data_provider_linux.h	View		1 chunk	+59 lines, -0 lines	0 comments	Download
A	chrome/browser/geolocation/wifi_data_provider_linux.cc	View		1 chunk	+279 lines, -0 lines	0 comments	Download
A	chrome/browser/geolocation/wifi_data_provider_osx.h	View		1 chunk	+71 lines, -0 lines	0 comments	Download
A	chrome/browser/geolocation/wifi_data_provider_osx.cc	View		1 chunk	+168 lines, -0 lines	0 comments	Download
A	chrome/browser/geolocation/wifi_data_provider_win.h	View		1 chunk	+87 lines, -0 lines	0 comments	Download
A	chrome/browser/geolocation/wifi_data_provider_win.cc	View		1 chunk	+534 lines, -0 lines	0 comments	Download
A	chrome/browser/geolocation/wifi_data_provider_windows_common.h	View		1 chunk	+45 lines, -0 lines	0 comments	Download
A	chrome/browser/geolocation/wifi_data_provider_windows_common.cc	View		1 chunk	+76 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

joth

take 2... is this the right way to temporarily silence checkdeps.py ?

10 years, 11 months ago (2010-01-25 18:55:31 UTC) #1

jorlow

10 years, 11 months ago (2010-01-25 19:16:00 UTC) #2

LGTM

http://codereview.chromium.org/556003/diff/1/15
File chrome/browser/DEPS (right):

http://codereview.chromium.org/556003/diff/1/15#newcode32
chrome/browser/DEPS:32: # checkdeps should skip geolocation for now, as it has
unmodified gears code.
Make this a TODO and be sure to remove it in the next patch.

Expand Messages | Collapse Messages