Issue 5560005: Update PDF user actions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5560005: Update PDF user actions. (Closed)

Created:
10 years ago by jam

Modified:
9 years, 7 months ago

Reviewers:
gene

CC:
chromium-reviews, pam+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Update PDF user actions. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=68262

Patch Set 1 #

Total comments: 1

Created: 10 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -0 lines)			Patch
	M	chrome/tools/chromeactions.txt	View		2 chunks	+3 lines, -0 lines	1 comment	Download
	M	chrome/tools/extract_actions.py	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

gene

LGTM A small question below. http://codereview.chromium.org/5560005/diff/1/chrome/tools/chromeactions.txt File chrome/tools/chromeactions.txt (right): http://codereview.chromium.org/5560005/diff/1/chrome/tools/chromeactions.txt#newcode16 chrome/tools/chromeactions.txt:16: 0x67b7031bb00a6917 AboutFlags_instant-type is this ...

10 years ago (2010-12-04 00:49:22 UTC) #2

jam

10 years ago (2010-12-04 01:07:34 UTC) #3

On Fri, Dec 3, 2010 at 4:49 PM, <gene@chromium.org> wrote:

> LGTM
> A small question below.
>
>
>
> http://codereview.chromium.org/5560005/diff/1/chrome/tools/chromeactions.txt
> File chrome/tools/chromeactions.txt (right):
>
>
>
http://codereview.chromium.org/5560005/diff/1/chrome/tools/chromeactions.txt#...
> chrome/tools/chromeactions.txt:16:
> 0x67b7031bb00a6917      AboutFlags_instant-type
> is this needed for PDF actions?


Someone added it without running the script to update the dashboard (which
is what builds the txt file).

>
>
> http://codereview.chromium.org/5560005/
>

Expand Messages | Collapse Messages