Issue 5559011: Remove ChromotingClientMessage

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5559011: Remove ChromotingClientMessage (Closed)

Created:
10 years ago by garykac

Modified:
9 years, 6 months ago

Reviewers:
Sergey Ulanov, dmac

CC:
chromium-reviews, Alpha Left Google, Sergey Ulanov, awong, garykac, Paweł Hajdan Jr.

Base URL:
http://git.chromium.org/git/chromium.git@trunk

Visibility:
Public.

Description

Remove ChromotingClientMessage BUG=None TEST=Remoting unittests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=68627

Patch Set 1 #

Total comments: 1

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+21 lines, -27 lines)			Patch
M	remoting/client/input_handler.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	remoting/host/event_executor_linux.cc	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	remoting/host/event_executor_win.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	remoting/proto/event.proto	View	1 chunk	+1 line, -1 line	1 comment	Download
M	remoting/proto/internal.proto	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	remoting/protocol/message_decoder_unittest.cc	View	5 chunks	+14 lines, -11 lines	0 comments	Download
M	remoting/protocol/mock_objects.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Sergey Ulanov

LGTM. Sorry for the delay. http://codereview.chromium.org/5559011/diff/1/remoting/proto/event.proto File remoting/proto/event.proto (right): http://codereview.chromium.org/5559011/diff/1/remoting/proto/event.proto#newcode16 remoting/proto/event.proto:16: // The POSIX key ...

10 years ago (2010-12-08 01:14:03 UTC) #2

LGTM as well (once you add a comment for sergey ;-) )

Expand Messages | Collapse Messages