Chromium Code Reviews

Issue 5559007: Fix ResourceServiceTest_UnpackPromoSignal_Test (Closed)

Created:
10 years ago by battre (please use the other)
Modified:
9 years, 7 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, ben+cc_chromium.org, Paweł Hajdan Jr., Miranda Callahan
Visibility:
Public.

Description

Fix ResourceServiceTest_UnpackPromoSignal_Test Fix for the following bug: [11725:11725:1206/035953:10306309386:ERROR:base/process_util_posix.cc(105)] Received signal 11 base::debug::StackTrace::StackTrace() [0x1f68261] base::(anonymous namespace)::StackDumpSignalHandler() [0x1fa2853] 0x2ba8f9b0f100 __pthread_mutex_lock_internal [0x2ba8f6dce423] LockImpl::Lock() [0x1f7a9f6] Lock::Acquire() [0x58a947] AutoLock::AutoLock() [0x58a979] MessageLoop::PostTask_Helper() [0x1f7e2cc] MessageLoop::PostDelayedTask() [0x1f7e40d] WebResourceService::ScheduleNotification() [0x158db6f] WebResourceService::UnpackPromoSignal() [0x158e1db] WebResourceServiceTest_UnpackPromoSignal_Test::TestBody() [0xcbb723] testing::HandleExceptionsInMethodIfSupported<>() [0x1b6ff6b] testing::Test::Run() [0x1b72cb9] testing::TestInfo::Run() [0x1b76548] testing::TestCase::Run() [0x1b7669b] testing::internal::UnitTestImpl::RunAllTests() [0x1b771f0] testing::HandleExceptionsInMethodIfSupported<>() [0x1b6fd4f] testing::UnitTest::Run() [0x1b6fdb7] base::TestSuite::Run() [0x33ed0a8] main [0x1a4f56d] 0x2ba8f9afb1c4 0x433829 Program received signal SIGSEGV, Segmentation fault. __pthread_mutex_lock (mutex=0x170) at pthread_mutex_lock.c:50 50 pthread_mutex_lock.c: No such file or directory. in pthread_mutex_lock.c (gdb) bt #0 __pthread_mutex_lock (mutex=0x170) at pthread_mutex_lock.c:50 #1 0x00007ffff5ac327d in LockImpl::Lock (this=0x170) at base/lock_impl_posix.cc:41 #2 0x00007ffff5a85dee in Lock::Acquire (this=0x168) at ./base/lock.h:40 #3 0x00007ffff5a85e50 in AutoLock::AutoLock (this=0x7fffffffd450, lock=...) at ./base/lock.h:95 #4 0x00007ffff5ac7a16 in MessageLoop::PostTask_Helper (this=0x0, from_here=..., task=0x7fffe29a8e00, delay_ms=1974154931, nestable=true) at base/message_loop.cc:378 #5 0x00007ffff5ac7816 in MessageLoop::PostDelayedTask (this=0x0, from_here=..., task=0x7fffe29a8e00, delay_ms=1974154931) at base/message_loop.cc:318 #6 0x00007ffff77009e1 in WebResourceService::ScheduleNotification (this=0x7fffe41ed4e0, promo_start=1264899600, promo_end=1327971600) at chrome/browser/web_resource/web_resource_service.cc:285 Note how this is NULL in MessageLoop::PostDelayedTask. Patch from Dominic Battré (battre@google.com) BUG=65462 TEST=none TBR=mirandac Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=68349

Patch Set 1 #

Patch Set 2 : This CL also activates the test again #

Unified diffs Side-by-side diffs Stats (+4 lines, -2 lines)
M chrome/browser/web_resource/web_resource_service_unittest.cc View 2 chunks +4 lines, -2 lines 0 comments

Messages

Total messages: 2 (0 generated)
battre (please use the other)
10 years ago (2010-12-06 12:43:46 UTC) #1
Bernhard Bauer
10 years ago (2010-12-06 12:55:07 UTC) #2
LGTM.

Powered by Google App Engine