Issue 5559004: chromeos: Add support for multiple volume icons.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5559004: chromeos: Add support for multiple volume icons. (Closed)

Created:
10 years ago by Daniel Erat

Modified:
9 years, 7 months ago

Reviewers:
glotov

CC:
chromium-reviews, davemoore+watch_chromium.org, ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/chrome/browser/chromeos

Visibility:
Public.

Description

chromeos: Add support for multiple volume icons. This makes us the appropriate icon depending on whether the volume is increasing, decreasing, or muted. BUG=chromium-os:8473 TEST=built it and tried the volume up, down, and mute keys in various combinations Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=68387

Patch Set 1 #

Patch Set 2 : merge #

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+48 lines, -16 lines)			Patch
M	chrome/app/theme/theme_resources.grd	View	1	1 chunk	+3 lines, -1 line	0 comments	Download
D	chrome/app/theme/volume_icon.png	View		Binary file		0 comments	Download
M	chrome/browser/chromeos/setting_level_bubble.h	View		2 chunks	+8 lines, -3 lines	0 comments	Download
M	chrome/browser/chromeos/setting_level_bubble.cc	View		3 chunks	+15 lines, -3 lines	0 comments	Download
M	chrome/browser/chromeos/setting_level_bubble_view.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/setting_level_bubble_view.cc	View		4 chunks	+14 lines, -8 lines	0 comments	Download
M	chrome/browser/chromeos/volume_bubble.cc	View	1	1 chunk	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM
On 2010/12/03 23:11:44, Daniel Erat wrote:

Expand Messages | Collapse Messages