Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(864)

Issue 5558009: Fix arm gyp files, lithium files where not added. (Closed)

Created:
10 years ago by Rico
Modified:
9 years, 6 months ago
Reviewers:
Kasper Lund
CC:
v8-dev
Visibility:
Public.

Description

Fix arm gyp files, lithium files where not added. Committed: http://code.google.com/p/v8/source/detail?r=5938

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M tools/gyp/v8.gyp View 1 2 chunks +5 lines, -1 line 2 comments Download

Messages

Total messages: 3 (0 generated)
Rico
10 years ago (2010-12-07 15:42:58 UTC) #1
Kasper Lund
LGTM! http://codereview.chromium.org/5558009/diff/3001/tools/gyp/v8.gyp File tools/gyp/v8.gyp (right): http://codereview.chromium.org/5558009/diff/3001/tools/gyp/v8.gyp#newcode543 tools/gyp/v8.gyp:543: '../../src/arm/lithium-codegen-arm.cc', -arm before -codegen.
10 years ago (2010-12-07 15:44:12 UTC) #2
Rico
10 years ago (2010-12-07 15:46:28 UTC) #3
http://codereview.chromium.org/5558009/diff/3001/tools/gyp/v8.gyp
File tools/gyp/v8.gyp (right):

http://codereview.chromium.org/5558009/diff/3001/tools/gyp/v8.gyp#newcode543
tools/gyp/v8.gyp:543: '../../src/arm/lithium-codegen-arm.cc',
On 2010/12/07 15:44:12, Kasper Lund wrote:
> -arm before -codegen.
Not according to the filenames

Powered by Google App Engine
This is Rietveld 408576698