Issue 5558009: Fix arm gyp files, lithium files where not added.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5558009: Fix arm gyp files, lithium files where not added. (Closed)

Created:
10 years ago by Rico

Modified:
9 years, 6 months ago

Reviewers:
Kasper Lund

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Fix arm gyp files, lithium files where not added. Committed: http://code.google.com/p/v8/source/detail?r=5938

Patch Set 2 : '' #

Total comments: 2

Created: 10 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -1 line)			Patch
	M	tools/gyp/v8.gyp	View	1	2 chunks	+5 lines, -1 line	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Kasper Lund

LGTM! http://codereview.chromium.org/5558009/diff/3001/tools/gyp/v8.gyp File tools/gyp/v8.gyp (right): http://codereview.chromium.org/5558009/diff/3001/tools/gyp/v8.gyp#newcode543 tools/gyp/v8.gyp:543: '../../src/arm/lithium-codegen-arm.cc', -arm before -codegen.

10 years ago (2010-12-07 15:44:12 UTC) #2

Rico

10 years ago (2010-12-07 15:46:28 UTC) #3

http://codereview.chromium.org/5558009/diff/3001/tools/gyp/v8.gyp
File tools/gyp/v8.gyp (right):

http://codereview.chromium.org/5558009/diff/3001/tools/gyp/v8.gyp#newcode543
tools/gyp/v8.gyp:543: '../../src/arm/lithium-codegen-arm.cc',
On 2010/12/07 15:44:12, Kasper Lund wrote:
> -arm before -codegen.
Not according to the filenames

Expand Messages | Collapse Messages

Issue 5558009: Fix arm gyp files, lithium files where not added. (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Messages