Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(641)

Issue 5557001: Remove expectations from downstream test_expecations.... (Closed)

Created:
10 years ago by Julie Parent
Modified:
9 years, 7 months ago
Reviewers:
Victor Wang
CC:
chromium-reviews, darin-cc_chromium.org, pam+watch_chromium.org
Visibility:
Public.

Description

Remove expectations from downstream test_expecations. It was moved upstream in r73093. TEST=none BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=68032

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M webkit/tools/layout_tests/test_expectations.txt View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Julie Parent
10 years ago (2010-12-02 03:07:32 UTC) #1
Julie Parent
(I won't commit until next WebKit roll pulls in the test_expecations update) On Wed, Dec ...
10 years ago (2010-12-02 03:08:28 UTC) #2
Victor Wang
10 years ago (2010-12-02 03:11:09 UTC) #3
LGTM

On 2010/12/02 03:08:28, Julie Parent wrote:
> (I won't commit until next WebKit roll pulls in the test_expecations update)
> 
> On Wed, Dec 1, 2010 at 7:07 PM, <mailto:jparent@chromium.org> wrote:
> 
> > Reviewers: Victor Wang,
> >
> > Description:
> > Remove expectations from downstream test_expecations.
> > It was moved upstream in r73093.
> >
> > TEST=none
> > BUG=none
> >
> >
> > Please review this at http://codereview.chromium.org/5557001/
> >
> > SVN Base: svn://svn.chromium.org/chrome/trunk/src/
> >
> > Affected files:
> >  M     webkit/tools/layout_tests/test_expectations.txt
> >
> >
> > Index: webkit/tools/layout_tests/test_expectations.txt
> > ===================================================================
> > --- webkit/tools/layout_tests/test_expectations.txt     (revision 67941)
> > +++ webkit/tools/layout_tests/test_expectations.txt     (working copy)
> > @@ -5,9 +5,6 @@
> >  // Only add expectations here to temporarily suppress messages on the bots
> >  // until the changes can be landed upstream.
> >
> > -// Not sure when this started crashing, seen on my webkit roll, but was
> > crashing before that.
> > -BUG_JPARENT LINUX : fast/dom/HTMLHeadElement/head-check.html = CRASH PASS
> > -
> >  // Started to flake since
> > http://src.chromium.org/viewvc/chrome?view=rev&revision=66937
> >  // (72440; 72514] range
> >  BUG_ANTON LINUX : fast/ruby/nested-ruby.html = CRASH PASS IMAGE
> >
> >
> >

Powered by Google App Engine
This is Rietveld 408576698