Issue 5556007: [Mac] Re-color omnibox text and move the cursor to the end when committing su...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5556007: [Mac] Re-color omnibox text and move the cursor to the end when committing su... (Closed)

Created:
10 years ago by rohitrao (ping after 24h)

Modified:
9 years, 7 months ago

Reviewers:
Nico, isherman

CC:
chromium-reviews, pam+watch_chromium.org, ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

[Mac] Re-color omnibox text and move the cursor to the end when committing suggest text. BUG=65464 TEST=Type "hello" into the omnibox. When the suggestion appears, press right (or tab). Suggest text should turn black. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=68370

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2

Patch Set 3 : '' #

Created: 10 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	chrome/browser/autocomplete/autocomplete_edit_view_mac.mm	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Nico

LG without log spew. I guess this is safe enough to merge it. http://codereview.chromium.org/5556007/diff/3001/chrome/browser/autocomplete/autocomplete_edit_view_mac.mm File ...

10 years ago (2010-12-06 04:07:51 UTC) #2

rohitrao (ping after 24h)

10 years ago (2010-12-06 19:46:29 UTC) #3

I'll ask kerz/jeff about merging, since the original bug was just marked M10.

http://codereview.chromium.org/5556007/diff/3001/chrome/browser/autocomplete/...
File chrome/browser/autocomplete/autocomplete_edit_view_mac.mm (right):

http://codereview.chromium.org/5556007/diff/3001/chrome/browser/autocomplete/...
chrome/browser/autocomplete/autocomplete_edit_view_mac.mm:776: LOG(ERROR) <<
"Committing suggest";
On 2010/12/06 04:07:51, Nico wrote:
> remove?

Silly log spam.  Gone.

Expand Messages | Collapse Messages