Issue 5552003: Login pod visual enhancements.

Issue 5552003: Login pod visual enhancements. (Closed)

Created:
10 years ago by altimofeev

Modified:
9 years, 7 months ago

Reviewers:
Nikita (slow)

CC:
chromium-reviews, nkostylev+cc_chromium.org, davemoore+watch_chromium.org, ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/chrome/browser/chromeos/login

Visibility:
Public.

Description

Login pod visual enhancements. 1. Do not fade out the background and text at the same time. 2. Fixed username shape on the screen lock. 3. Fixed corners drawing for the user image. 4. Do not use rounded corners for 'add user' pod (it cased the white frame blinking) 5. Do not use rounded corners for the unselected label, since the user image is scaled and the frame almost disappears. BUG=chromium-os:9721 TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=68842

Patch Set 1 #

Patch Set 2 : smoothing #

Patch Set 3 : make up #

Patch Set 4 : don't use rounded view for 'add user' #

Patch Set 5 : mergind mode fixed #

Total comments: 2

Patch Set 6 : special frame for the unselected label #

Total comments: 6

Patch Set 7 : nits #

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+178 lines, -85 lines)			Patch
M	chrome/browser/chromeos/login/rounded_view.h	View	1 2 3 4 5 6	3 chunks	+23 lines, -6 lines	0 comments	Download
M	chrome/browser/chromeos/login/screen_lock_view.cc	View	1 2 3 4 5	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/login/user_controller.cc	View	1 2 3 4 5	3 chunks	+11 lines, -32 lines	0 comments	Download
M	chrome/browser/chromeos/login/user_view.cc	View	1 2 3	1 chunk	+6 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/login/username_view.h	View	1 2 3 4 5 6	1 chunk	+13 lines, -4 lines	0 comments	Download
M	chrome/browser/chromeos/login/username_view.cc	View	1 2 3 4 5 6	2 chunks	+124 lines, -41 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

altimofeev

Screenshots: http://www.corp.google.com/~altimofeev/screenshots/logins.html

10 years ago (2010-12-06 17:41:55 UTC) #1

Nikita (slow)

Side issue: I've noticed that on screenshots that label is drawn over the 1px light ...

10 years ago (2010-12-06 18:03:54 UTC) #2

altimofeev

On 2010/12/06 18:03:54, Nikita Kostylev wrote: > Side issue: I've noticed that on screenshots that ...

10 years ago (2010-12-07 08:43:06 UTC) #3

Nikita (slow)

LGTM with nits http://codereview.chromium.org/5552003/diff/13001/chrome/browser/chromeos/login/rounded_view.h File chrome/browser/chromeos/login/rounded_view.h (right): http://codereview.chromium.org/5552003/diff/13001/chrome/browser/chromeos/login/rounded_view.h#newcode56 chrome/browser/chromeos/login/rounded_view.h:56: //canvas->AsCanvasSkia()->drawColor(0xFFFFFFFF); Remove? http://codereview.chromium.org/5552003/diff/17001/chrome/browser/chromeos/login/user_controller.cc File chrome/browser/chromeos/login/user_controller.cc (right): ...

10 years ago (2010-12-07 09:32:40 UTC) #4

altimofeev

10 years ago (2010-12-10 10:25:25 UTC) #5

http://codereview.chromium.org/5552003/diff/13001/chrome/browser/chromeos/log...
File chrome/browser/chromeos/login/rounded_view.h (right):

http://codereview.chromium.org/5552003/diff/13001/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/rounded_view.h:56:
//canvas->AsCanvasSkia()->drawColor(0xFFFFFFFF);
On 2010/12/07 09:32:40, Nikita Kostylev wrote:
> Remove?

Done.

http://codereview.chromium.org/5552003/diff/17001/chrome/browser/chromeos/log...
File chrome/browser/chromeos/login/user_controller.cc (right):

http://codereview.chromium.org/5552003/diff/17001/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/user_controller.cc:476: // TODO(altimofeev):
switch to the rounded username view.
On 2010/12/07 09:32:40, Nikita Kostylev wrote:
> Should file a P2 cleanup issue?

Actually, it is not a cleanup. The problem is that we currently get the small
user image using scaling. It implies that image frame is scaled too. So
unselected label can't use regular rounded shape.

There is already issue about custom frame for the small user image - issue 8917.

http://codereview.chromium.org/5552003/diff/17001/chrome/browser/chromeos/log...
File chrome/browser/chromeos/login/username_view.cc (right):

http://codereview.chromium.org/5552003/diff/17001/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/username_view.cc:174: UsernameView*
UsernameView::CreateShapedUsernameView(
On 2010/12/07 09:32:40, Nikita Kostylev wrote:
> // static
> 
> Should go after Paint to follow header method order.

Done.

http://codereview.chromium.org/5552003/diff/17001/chrome/browser/chromeos/log...
File chrome/browser/chromeos/login/username_view.h (right):

http://codereview.chromium.org/5552003/diff/17001/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/username_view.h:29: // gets the ownership.
On 2010/12/07 09:32:40, Nikita Kostylev wrote:
> Comment about |use_small_shape|, when it's used.

Done.

Expand Messages | Collapse Messages