Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 555192: Add a utility function to run a process as an arbitrary user... (Closed)

Created:
10 years, 10 months ago by cpu_(ooo_6.6-7.5)
Modified:
9 years, 7 months ago
Reviewers:
ananta
CC:
chromium-reviews, brettw+cc_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Add a utility function to run a process as an arbitrary user - Only for windows - Needed in certain upgrade scenarios, useful for all BUG=32474 TEST= unit tests included Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=37682

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -15 lines) Patch
M base/multiprocess_test.h View 2 chunks +14 lines, -15 lines 0 comments Download
M base/process.h View 1 chunk +1 line, -0 lines 0 comments Download
M base/process_util.h View 1 chunk +14 lines, -0 lines 0 comments Download
M base/process_util_unittest.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M base/process_util_win.cc View 3 chunks +40 lines, -0 lines 1 comment Download

Messages

Total messages: 3 (0 generated)
cpu_(ooo_6.6-7.5)
10 years, 10 months ago (2010-01-31 02:28:46 UTC) #1
ananta
LGTM http://codereview.chromium.org/555192/diff/1/6 File base/process_util_win.cc (right): http://codereview.chromium.org/555192/diff/1/6#newcode171 base/process_util_win.cc:171: bool start_hidden, ProcessHandle* process_handle) { Would it make ...
10 years, 10 months ago (2010-02-01 00:52:28 UTC) #2
cpu_(ooo_6.6-7.5)
10 years, 10 months ago (2010-02-01 03:27:55 UTC) #3
Thanks for the prompt review!

I considered your comment but it clashes too much with the style of the other
processxxxx functions.


On 2010/02/01 00:52:28, ananta wrote:
> LGTM
> 
> http://codereview.chromium.org/555192/diff/1/6
> File base/process_util_win.cc (right):
> 
> http://codereview.chromium.org/555192/diff/1/6#newcode171
> base/process_util_win.cc:171: bool start_hidden, ProcessHandle*
process_handle)
> {
> Would it make sense to take in the desired STARTUPINFO as a parameter instead?

Powered by Google App Engine
This is Rietveld 408576698