Show user script source line that caused exception intead of a line in a nati...

Show user script source line that caused exception intead of a line in a native script. When an error is reported as one happened in a native script it's hard to track the original cause. See chromium issue: http://crbug.com/25305

Committed: http://code.google.com/p/v8/source/detail?r=3753

[Søren Thygesen Gjesse, 2010-02-01 09:21:20]

LGTM

Consider adding a test to tets/mjsunit/stack-traces.js as well.

[yurys, 2010-02-01 10:27:40]

Runtime_CollectStackTrace doesn't use StackTraceFrameIterator and is not
affected by this change. I'm not sure if we want to exclude all the frames with
functions from native scripts. If we want to do so, we could probably use
StackTraceFrameIterator instead of StackFrameIterator in
Runtime_CollectStackTrace. Probably it's not that bad to show builtin functions
in the stack trace since in the case of stack trace user is still able to track
the source of error  (unlike error message handler where the stack may not be
available).

On 2010/02/01 09:21:20, Søren Gjesse wrote:
> LGTM
> 
> Consider adding a test to tets/mjsunit/stack-traces.js as well.

[yurys, 2010-02-01 10:28:52]

I could prepare another change that changes exception stack trace behavior if we
agree that it's the right approach.

On 2010/02/01 10:27:40, Yury Semikhatsky wrote:
> Runtime_CollectStackTrace doesn't use StackTraceFrameIterator and is not
> affected by this change. I'm not sure if we want to exclude all the frames
with
> functions from native scripts. If we want to do so, we could probably use
> StackTraceFrameIterator instead of StackFrameIterator in
> Runtime_CollectStackTrace. Probably it's not that bad to show builtin
functions
> in the stack trace since in the case of stack trace user is still able to
track
> the source of error  (unlike error message handler where the stack may not be
> available).
> 
> On 2010/02/01 09:21:20, Søren Gjesse wrote:
> > LGTM
> > 
> > Consider adding a test to tets/mjsunit/stack-traces.js as well.