Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Side by Side Diff: src/x64/debug-x64.cc

Issue 555164: Fix exit frame type in breakpoint stub (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: '' Created 10 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« src/codegen.cc ('K') | « src/x64/codegen-x64.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2010 the V8 project authors. All rights reserved. 1 // Copyright 2010 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 50 matching lines...) Expand 10 before | Expand all | Expand 10 after
61 // Store the registers containing object pointers on the expression stack to 61 // Store the registers containing object pointers on the expression stack to
62 // make sure that these are correctly updated during GC. 62 // make sure that these are correctly updated during GC.
63 __ PushRegistersFromMemory(pointer_regs); 63 __ PushRegistersFromMemory(pointer_regs);
64 64
65 #ifdef DEBUG 65 #ifdef DEBUG
66 __ RecordComment("// Calling from debug break to runtime - come in - over"); 66 __ RecordComment("// Calling from debug break to runtime - come in - over");
67 #endif 67 #endif
68 __ xor_(rax, rax); // No arguments (argc == 0). 68 __ xor_(rax, rax); // No arguments (argc == 0).
69 __ movq(rbx, ExternalReference::debug_break()); 69 __ movq(rbx, ExternalReference::debug_break());
70 70
71 CEntryStub ceb(1); 71 CEntryStub ceb(1, ExitFrame::MODE_DEBUG);
72 __ CallStub(&ceb); 72 __ CallStub(&ceb);
73 73
74 // Restore the register values containing object pointers from the expression 74 // Restore the register values containing object pointers from the expression
75 // stack in the reverse order as they where pushed. 75 // stack in the reverse order as they where pushed.
76 __ PopRegistersToMemory(pointer_regs); 76 __ PopRegistersToMemory(pointer_regs);
77 77
78 // Get rid of the internal frame. 78 // Get rid of the internal frame.
79 __ LeaveInternalFrame(); 79 __ LeaveInternalFrame();
80 80
81 // If this call did not replace a call but patched other code then there will 81 // If this call did not replace a call but patched other code then there will
(...skipping 112 matching lines...) Expand 10 before | Expand all | Expand 10 after
194 void BreakLocationIterator::SetDebugBreakAtReturn() { 194 void BreakLocationIterator::SetDebugBreakAtReturn() {
195 ASSERT(Assembler::kJSReturnSequenceLength >= 195 ASSERT(Assembler::kJSReturnSequenceLength >=
196 Assembler::kCallInstructionLength); 196 Assembler::kCallInstructionLength);
197 rinfo()->PatchCodeWithCall(Debug::debug_break_return()->entry(), 197 rinfo()->PatchCodeWithCall(Debug::debug_break_return()->entry(),
198 Assembler::kJSReturnSequenceLength - Assembler::kCallInstructionLength); 198 Assembler::kJSReturnSequenceLength - Assembler::kCallInstructionLength);
199 } 199 }
200 200
201 #endif // ENABLE_DEBUGGER_SUPPORT 201 #endif // ENABLE_DEBUGGER_SUPPORT
202 202
203 } } // namespace v8::internal 203 } } // namespace v8::internal
OLDNEW
« src/codegen.cc ('K') | « src/x64/codegen-x64.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698