Fix exit frame type in breakpoint stub

src/codegen.cc

 // Copyright 2009 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 461 matching lines @@
 
 void ArgumentsAccessStub::Generate(MacroAssembler* masm) {
   switch (type_) {
     case READ_LENGTH: GenerateReadLength(masm); break;
     case READ_ELEMENT: GenerateReadElement(masm); break;
     case NEW_OBJECT: GenerateNewObject(masm); break;
   }
 }
 
 
+int CEntryStub::MinorKey() {
+  ASSERT(result_size_ <= 2);
+#ifdef _WIN64
+  const indirect_result = result_size_ > 1;

[William Hesse, 2010/02/03 06:18:35]

This seems really wrong.  Either make the type (int) explicit, or make this a
constant bool.

+#else
+  const bool indirect_result = false;
+#endif
+
+  return ExitFrameModeBits::encode(mode_)
+         | IndirectResultBits::encode(indirect_result > 1);

[William Hesse, 2010/02/03 06:18:35]

Shouldn't this just be indirect_result, not indirect_result > 1?  The second
expression is never true.

In all cases except _WIN64, this is encoding 0, which probably doesn't affect
the bitwise or, so maybe the entire return statement should be in an #ifdef, and
be optimized in all cases except WIN64 to just return
ExitFrameModeBits::encode(mode).

+}
+
+
 bool ApiGetterEntryStub::GetCustomCache(Code** code_out) {
   Object* cache = info()->load_stub_cache();
   if (cache->IsUndefined()) {
     return false;
   } else {
     *code_out = Code::cast(cache);
     return true;
   }
 }
 
 
 void ApiGetterEntryStub::SetCustomCache(Code* value) {
   info()->set_load_stub_cache(value);
 }
 
 
 void DebugerStatementStub::Generate(MacroAssembler* masm) {
   Runtime::Function* f = Runtime::FunctionForId(Runtime::kDebugBreak);
   masm->TailCallRuntime(ExternalReference(f), 0, f->result_size);
 }
 
 
 } }  // namespace v8::internal