StoreIC interface changed on ia32 to take receiver in edx, not on stack.

StoreIC interface changed on ia32 to take receiver in edx, not on stack.

Committed: http://code.google.com/p/v8/source/detail?r=3750

[Kevin Millikin (Chromium), 2010-01-29 16:09:44]

STV.

http://codereview.chromium.org/555162/diff/1/6
File src/ia32/ic-ia32.cc (right):

http://codereview.chromium.org/555162/diff/1/6#newcode1416
src/ia32/ic-ia32.cc:1416: void StoreIC::Generate(MacroAssembler* masm, const
ExternalReference& f) {
I think StoreIC::Generate is always called with the same second argument.  It
seems like unneeded generality.

1. Rename StoreIC::Generate to StoreIC::GenerateMiss and make it public, remove
the second argument and replace the occurrence of 'f' with
'ExternalReference(IC_Utility(kStoreIC_Miss))'.

2. Delete the existing StoreIC::GenerateMiss implementation.

3. Replace the calls to StoreIC::Generate with StoreIC::GenerateMiss.

4. Go ahead and make StoreIC::GenerateInitialize an inline function (calling
GenerateMiss rather than Generate).

You can do that as a separate change if you just want to put this one in.

http://codereview.chromium.org/555162/diff/1/4
File src/ia32/virtual-frame-ia32.cc (right):

http://codereview.chromium.org/555162/diff/1/4#newcode907
src/ia32/virtual-frame-ia32.cc:907: PrepareForCall(0, 0);  // One stack arg, not
callee-dropped.
Change (or just delete) the comment.

[William Hesse, 2010-02-01 08:34:09]

http://codereview.chromium.org/555162/diff/1/6
File src/ia32/ic-ia32.cc (right):

http://codereview.chromium.org/555162/diff/1/6#newcode1416
src/ia32/ic-ia32.cc:1416: void StoreIC::Generate(MacroAssembler* masm, const
ExternalReference& f) {
Will do as separate change.

On 2010/01/29 16:09:44, Kevin Millikin wrote:
> I think StoreIC::Generate is always called with the same second argument.  It
> seems like unneeded generality.
> 
> 1. Rename StoreIC::Generate to StoreIC::GenerateMiss and make it public,
remove
> the second argument and replace the occurrence of 'f' with
> 'ExternalReference(IC_Utility(kStoreIC_Miss))'.
> 
> 2. Delete the existing StoreIC::GenerateMiss implementation.
> 
> 3. Replace the calls to StoreIC::Generate with StoreIC::GenerateMiss.
> 
> 4. Go ahead and make StoreIC::GenerateInitialize an inline function (calling
> GenerateMiss rather than Generate).
> 
> You can do that as a separate change if you just want to put this one in.

http://codereview.chromium.org/555162/diff/1/4
File src/ia32/virtual-frame-ia32.cc (right):

http://codereview.chromium.org/555162/diff/1/4#newcode907
src/ia32/virtual-frame-ia32.cc:907: PrepareForCall(0, 0);  // One stack arg, not
callee-dropped.
On 2010/01/29 16:09:44, Kevin Millikin wrote:
> Change (or just delete) the comment.

Done.