Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 555162: StoreIC interface changed on ia32 to take receiver in edx, not on stack. (Closed)

Created:
10 years, 10 months ago by William Hesse
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

StoreIC interface changed on ia32 to take receiver in edx, not on stack. Committed: http://code.google.com/p/v8/source/detail?r=3750

Patch Set 1 #

Total comments: 4

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -53 lines) Patch
M src/ia32/codegen-ia32.cc View 1 2 chunks +1 line, -3 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 5 chunks +13 lines, -8 lines 0 comments Download
M src/ia32/ic-ia32.cc View 1 3 chunks +5 lines, -7 lines 0 comments Download
M src/ia32/stub-cache-ia32.cc View 1 6 chunks +14 lines, -24 lines 0 comments Download
M src/ia32/virtual-frame-ia32.cc View 1 1 chunk +25 lines, -11 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
William Hesse
10 years, 10 months ago (2010-01-29 13:33:47 UTC) #1
Kevin Millikin (Chromium)
STV. http://codereview.chromium.org/555162/diff/1/6 File src/ia32/ic-ia32.cc (right): http://codereview.chromium.org/555162/diff/1/6#newcode1416 src/ia32/ic-ia32.cc:1416: void StoreIC::Generate(MacroAssembler* masm, const ExternalReference& f) { I ...
10 years, 10 months ago (2010-01-29 16:09:44 UTC) #2
William Hesse
10 years, 10 months ago (2010-02-01 08:34:09 UTC) #3
http://codereview.chromium.org/555162/diff/1/6
File src/ia32/ic-ia32.cc (right):

http://codereview.chromium.org/555162/diff/1/6#newcode1416
src/ia32/ic-ia32.cc:1416: void StoreIC::Generate(MacroAssembler* masm, const
ExternalReference& f) {
Will do as separate change.

On 2010/01/29 16:09:44, Kevin Millikin wrote:
> I think StoreIC::Generate is always called with the same second argument.  It
> seems like unneeded generality.
> 
> 1. Rename StoreIC::Generate to StoreIC::GenerateMiss and make it public,
remove
> the second argument and replace the occurrence of 'f' with
> 'ExternalReference(IC_Utility(kStoreIC_Miss))'.
> 
> 2. Delete the existing StoreIC::GenerateMiss implementation.
> 
> 3. Replace the calls to StoreIC::Generate with StoreIC::GenerateMiss.
> 
> 4. Go ahead and make StoreIC::GenerateInitialize an inline function (calling
> GenerateMiss rather than Generate).
> 
> You can do that as a separate change if you just want to put this one in.

http://codereview.chromium.org/555162/diff/1/4
File src/ia32/virtual-frame-ia32.cc (right):

http://codereview.chromium.org/555162/diff/1/4#newcode907
src/ia32/virtual-frame-ia32.cc:907: PrepareForCall(0, 0);  // One stack arg, not
callee-dropped.
On 2010/01/29 16:09:44, Kevin Millikin wrote:
> Change (or just delete) the comment.

Done.

Powered by Google App Engine
This is Rietveld 408576698