Issue 555147: Use registers to pass arguments to GenericBinaryOpStub (x64)....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 555147: Use registers to pass arguments to GenericBinaryOpStub (x64).... (Closed)

Created:
10 years, 11 months ago by Vladislav Kaznacheev

Modified:
9 years, 7 months ago

Reviewers:
Kevin Millikin (Chromium), Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Use registers to pass arguments to GenericBinaryOpStub (x64). This is a port to x64 of the following CLs: http://codereview.chromium.org/554062 (use registers at all) http://codereview.chromium.org/555098 (use registers for MUL, DIV and virtual frames) http://codereview.chromium.org/556019 (optimize register order) Committed: http://code.google.com/p/v8/source/detail?r=3735

Patch Set 1 #

Total comments: 6

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+196 lines, -100 lines)			Patch
M	src/x64/codegen-x64.h	View	3 chunks	+9 lines, -5 lines	0 comments	Download
M	src/x64/codegen-x64.cc	View	15 chunks	+186 lines, -92 lines	6 comments	Download
M	src/x64/full-codegen-x64.cc	View	1 chunk	+1 line, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

LGTM http://codereview.chromium.org/555147/diff/1/3 File src/x64/codegen-x64.cc (right): http://codereview.chromium.org/555147/diff/1/3#newcode7503 src/x64/codegen-x64.cc:7503: Register left = rdx; Does it add much ...

10 years, 11 months ago (2010-01-28 12:32:09 UTC) #2

Vladislav Kaznacheev

10 years, 11 months ago (2010-01-28 12:38:19 UTC) #3

http://codereview.chromium.org/555147/diff/1/3
File src/x64/codegen-x64.cc (right):

http://codereview.chromium.org/555147/diff/1/3#newcode7503
src/x64/codegen-x64.cc:7503: Register left = rdx;
On 2010/01/28 12:32:09, Mads Ager wrote:
> Does it add much to rename to left and right here.  The method is so short
that
> I don't think it makes it easier to read.

Done.

http://codereview.chromium.org/555147/diff/1/3#newcode7515
src/x64/codegen-x64.cc:7515: Register left = rdx;
On 2010/01/28 12:32:09, Mads Ager wrote:
> Same here.

Done.

http://codereview.chromium.org/555147/diff/1/3#newcode7925
src/x64/codegen-x64.cc:7925: // edx and eax.
On 2010/01/28 12:32:09, Mads Ager wrote:
> edx -> rdx
> eax -> rax

Done.

Expand Messages | Collapse Messages