[Mac] Prevent script-initiated tab close while a content select menu is up.

[Mac] Prevent script-initiated tab close while a content select menu is up.

BUG=31716
TEST=test.html from the bug, page shouldn't close while select popup is up.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=37417

[Scott Hess - ex-Googler, 2010-01-28 01:29:12]

So awesome.

[viettrungluu, 2010-01-28 01:32:19]

Probably you should give this a different title (not "Pin"), lest it be confused
with, well, pinning tabs. Other than this and the nits, LG.

http://codereview.chromium.org/555144/diff/1/2
File chrome/browser/renderer_host/render_widget_host_view_mac.mm (right):

http://codereview.chromium.org/555144/diff/1/2#newcode412
chrome/browser/renderer_host/render_widget_host_view_mac.mm:412: // One of the
events that could be pumped is window.close().
Code (here and below) should be put between |...| in comments.

http://codereview.chromium.org/555144/diff/1/2#newcode414
chrome/browser/renderer_host/render_widget_host_view_mac.mm:414: // protections
in -sendEvent: are not in place, so fake it until
Probably you should be more explicit than "fake it".

[Scott Hess - ex-Googler, 2010-01-28 18:44:11]

Hacked on the comment and title.  Another look?

[viettrungluu, 2010-01-28 18:46:17]

On 2010/01/28 18:44:11, shess wrote:
> Hacked on the comment and title.  Another look?

Good enough for (standard-def) TV. LGTM.