Issue 5551002: Simplify JSON stringify and add special case for default replacer and space.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5551002: Simplify JSON stringify and add special case for default replacer and space. (Closed)

Created:
10 years ago by sandholm

Modified:
9 years, 7 months ago

Reviewers:
William Hesse

CC:
v8-dev, Lasse Reichstein

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Simplify JSON stringify and add special case for default replacer and space.

Patch Set 1 #

Patch Set 2 : '' #

Created: 10 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+88 lines, -24 lines)			Patch
	M	src/json.js	View	1	6 chunks	+73 lines, -12 lines	0 comments	Download
	M	src/runtime.cc	View	1	3 chunks	+15 lines, -12 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

William Hesse

LGTM, with my comments about putting more of the string concatenations in the Array.join, with ...

10 years ago (2010-12-02 16:12:22 UTC) #2

sandholm

10 years ago (2010-12-03 11:11:32 UTC) #3

On 2010/12/02 16:12:22, William Hesse wrote:
> LGTM, with my comments about putting more of the string concatenations in the
> Array.join, with an empty separator.

I tried that. It was slower, unfortunately.

Expand Messages | Collapse Messages