Issue 555049: Ported SubStringStub to X64.

Issue 555049: Ported SubStringStub to X64. (Closed)

Created:
10 years, 11 months ago by Lasse Reichstein

Modified:
9 years, 6 months ago

Reviewers:
Søren Thygesen Gjesse

CC:
v8-dev

Visibility:
Public.

Patch Set 1 #

Total comments: 8

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+337 lines, -17 lines)			Patch
M	src/x64/assembler-x64.h	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	src/x64/assembler-x64.cc	View	1 chunk	+34 lines, -0 lines	0 comments	Download
M	src/x64/codegen-x64.h	View	3 chunks	+36 lines, -7 lines	0 comments	Download
M	src/x64/codegen-x64.cc	View	3 chunks	+173 lines, -6 lines	8 comments	Download
M	src/x64/disasm-x64.cc	View	4 chunks	+27 lines, -3 lines	0 comments	Download
M	src/x64/macro-assembler-x64.h	View	3 chunks	+16 lines, -0 lines	0 comments	Download
M	src/x64/macro-assembler-x64.cc	View	4 chunks	+44 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Søren Thygesen Gjesse

LGTM http://codereview.chromium.org/555049/diff/1/4 File src/x64/codegen-x64.cc (right): http://codereview.chromium.org/555049/diff/1/4#newcode8185 src/x64/codegen-x64.cc:8185: if (!ascii) { ASSERT(kShortSize == 2); http://codereview.chromium.org/555049/diff/1/4#newcode8197 src/x64/codegen-x64.cc:8197: ...

10 years, 11 months ago (2010-01-25 08:31:33 UTC) #2

Lasse Reichstein

10 years, 11 months ago (2010-01-25 08:47:19 UTC) #3

http://codereview.chromium.org/555049/diff/1/4
File src/x64/codegen-x64.cc (right):

http://codereview.chromium.org/555049/diff/1/4#newcode8185
src/x64/codegen-x64.cc:8185: if (!ascii) {
It's not really the size of short ints that matter, but the size of UC16 (or
really, the size of characters in SequentialTwoByteString, which kindof gives
itself :)
I'll add sizeof test for uc16.

http://codereview.chromium.org/555049/diff/1/4#newcode8197
src/x64/codegen-x64.cc:8197: __ repmovsl();
Probably, since we expect long strings, the tine spent one having the secondary
loop be 0-7 characters instead of 0-3 should be saved on the first loop.

http://codereview.chromium.org/555049/diff/1/4#newcode8233
src/x64/codegen-x64.cc:8233: const int kStringOffset = 3 * kPointerSize;
Done.

Expand Messages | Collapse Messages