Maintainer script for flash ++

Maintainer script for flash
Fix chrome packaging (wrong symlink for plugin directory)
Pass architecture (ARCH) down from install_packages.sh
Remove tar from prod package list

[tedbo, 2010-01-21 04:35:12]

Some comments/questions below.

http://codereview.chromium.org/555027/diff/1/2
File src/package_repo/package-list-prod.txt (left):

http://codereview.chromium.org/555027/diff/1/2#oldcode28
src/package_repo/package-list-prod.txt:28: tar
Aside from the flash maintainer script, "tar" is needed for apt to be able to
install packages. Please leave it in the prod image for now.

http://codereview.chromium.org/555027/diff/1/3
File src/package_scripts/flashplugin-installer.postinst (right):

http://codereview.chromium.org/555027/diff/1/3#newcode27
src/package_scripts/flashplugin-installer.postinst:27: cd
"${SRC_ROOT}/build/${ARCH}/local_assets/"
I don't have a "local_assets" directory. I think that may only be in place if
you build chrome manually?

http://codereview.chromium.org/555027/diff/1/3#newcode31
src/package_scripts/flashplugin-installer.postinst:31: wget "${URL}/${FILENAME}"
It looks like the wget is accidentally indented?

[vandebo (ex-Chrome), 2010-01-21 05:05:11]

http://codereview.chromium.org/555027/diff/1/2
File src/package_repo/package-list-prod.txt (left):

http://codereview.chromium.org/555027/diff/1/2#oldcode28
src/package_repo/package-list-prod.txt:28: tar
On 2010/01/21 04:35:13, tedbo wrote:
> Aside from the flash maintainer script, "tar" is needed for apt to be able to
> install packages. Please leave it in the prod image for now.
> 

Done.

http://codereview.chromium.org/555027/diff/1/3
File src/package_scripts/flashplugin-installer.postinst (right):

http://codereview.chromium.org/555027/diff/1/3#newcode27
src/package_scripts/flashplugin-installer.postinst:27: cd
"${SRC_ROOT}/build/${ARCH}/local_assets/"
On 2010/01/21 04:35:13, tedbo wrote:
> I don't have a "local_assets" directory. I think that may only be in place if
> you build chrome manually?

The build instructions say to either build chrome, which will create the
directory, or to make the directory and drop a zip file of chrome in there.  So
theoretically you should have one (unless you already have a .deb of chrome).

So I added a check and created the directory if it was missing.

http://codereview.chromium.org/555027/diff/1/3#newcode31
src/package_scripts/flashplugin-installer.postinst:31: wget "${URL}/${FILENAME}"
On 2010/01/21 04:35:13, tedbo wrote:
> It looks like the wget is accidentally indented?
> 

Done.

[vandebo (ex-Chrome), 2010-01-21 05:38:48]

Give chrome a proper plugins directory.

[tedbo, 2010-01-21 05:49:31]

LGTM

Thanks.