Notify the AutoFillManager when the user clicks "Apply" or "OK". Adds an Aut...

Notify the AutoFillManager when the user clicks "Apply" or "OK".  Adds an AutoFillDialogObserver interface that is used to send the profile information back to clients.

BUG=none
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=36779

[sky, 2010-01-21 16:30:21]

http://codereview.chromium.org/555023/diff/1/4
File chrome/browser/autofill/autofill_dialog.h (right):

http://codereview.chromium.org/555023/diff/1/4#newcode40
chrome/browser/autofill/autofill_dialog.h:40: const std::vector<CreditCard>&
credit_cards) {
I think this results in multiple definitions. Move it to a .cc.

http://codereview.chromium.org/555023/diff/1/5
File chrome/browser/autofill/autofill_dialog_gtk.cc (right):

http://codereview.chromium.org/555023/diff/1/5#newcode356
chrome/browser/autofill/autofill_dialog_gtk.cc:356: return
UTF8ToUTF16(gtk_entry_get_text(GTK_ENTRY(entry)));
Should this be moved to gtk_util?

http://codereview.chromium.org/555023/diff/1/6
File chrome/browser/autofill/credit_card.h (right):

http://codereview.chromium.org/555023/diff/1/6#newcode18
chrome/browser/autofill/credit_card.h:18: explicit CreditCard(const CreditCard&
card);
Move the definition to match the location in the .h.

[James Hawkins, 2010-01-21 19:05:25]

http://codereview.chromium.org/555023/diff/1/4
File chrome/browser/autofill/autofill_dialog.h (right):

http://codereview.chromium.org/555023/diff/1/4#newcode40
chrome/browser/autofill/autofill_dialog.h:40: const std::vector<CreditCard>&
credit_cards) {
On 2010/01/21 16:30:21, sky wrote:
> I think this results in multiple definitions. Move it to a .cc.

Done.

http://codereview.chromium.org/555023/diff/1/5
File chrome/browser/autofill/autofill_dialog_gtk.cc (right):

http://codereview.chromium.org/555023/diff/1/5#newcode356
chrome/browser/autofill/autofill_dialog_gtk.cc:356: return
UTF8ToUTF16(gtk_entry_get_text(GTK_ENTRY(entry)));
On 2010/01/21 16:30:21, sky wrote:
> Should this be moved to gtk_util?

I grepped through the codebase, and all the other calls to gtk_entry_get_text
use UTF8ToWide, so I don't think anyone would benefit (yet) from moving this to
gtk_util.

http://codereview.chromium.org/555023/diff/1/6
File chrome/browser/autofill/credit_card.h (right):

http://codereview.chromium.org/555023/diff/1/6#newcode18
chrome/browser/autofill/credit_card.h:18: explicit CreditCard(const CreditCard&
card);
On 2010/01/21 16:30:21, sky wrote:
> Move the definition to match the location in the .h.

Gah, yea.  I wish that were in the linter.

[sky, 2010-01-21 19:26:58]

Did you forget to include the .cc containing ShowAutofillDialog?

[James Hawkins, 2010-01-21 19:32:42]

On 2010/01/21 19:26:58, sky wrote:
> Did you forget to include the .cc containing ShowAutofillDialog?

Indeed I did.  It's there now, thanks.

[James Hawkins, 2010-01-21 19:44:30]

On 2010/01/21 19:32:42, James Hawkins wrote:
> On 2010/01/21 19:26:58, sky wrote:
> > Did you forget to include the .cc containing ShowAutofillDialog?
> 
> Indeed I did.  It's there now, thanks.

I missed a blocking message on upload...so it's really there now.

[sky, 2010-01-21 20:14:23]

LGTM