Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Unified Diff: gpu/command_buffer/common/constants.h

Issue 555020: Redesigned CommandBuffer and NPDevice3D interfaces (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 10 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gpu/command_buffer/common/constants.h
===================================================================
--- gpu/command_buffer/common/constants.h (revision 37414)
+++ gpu/command_buffer/common/constants.h (working copy)
@@ -12,18 +12,7 @@
typedef int32 CommandBufferOffset;
const CommandBufferOffset kInvalidCommandBufferOffset = -1;
-// Status of the command buffer service. It does not process commands
-// (meaning: get will not change) unless in kParsing state.
-namespace parser_status {
- enum ParserStatus {
- kNotConnected, // The service is not connected - initial state.
- kNoBuffer, // The service is connected but no buffer was set.
- kParsing, // The service is connected, and parsing commands from the
- // buffer.
- kParseError, // Parsing stopped because a parse error was found.
- };
-}
-
+// TODO(apatrick): rename to something more generic like just Error.
namespace parse_error {
enum ParseError {
kParseNoError,
@@ -31,6 +20,7 @@
kParseOutOfBounds,
kParseUnknownCommand,
kParseInvalidArguments,
+ kParseGenericError,
};
}
« no previous file with comments | « gpu/command_buffer/common/command_buffer_mock.h ('k') | gpu/command_buffer/service/command_buffer_service.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698