Issue 555012: Removed restriction for {} so that javascript blocks can be used in the url....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 555012: Removed restriction for {} so that javascript blocks can be used in the url.... (Closed)

Created:
10 years, 11 months ago by whywhat

Modified:
9 years, 7 months ago

Reviewers:
sky

CC:
chromium-reviews_googlegroups.com, ben+cc_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Removed restriction for {} so that javascript blocks can be used in the url. Added unittests for TemplateURLRef::ParseParameter and TemplateURLRef::ParseURL methods. BUG=2238 TEST=Try adding urls with different combinations of {}, they all should work. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=36743

Patch Set 1 #

Total comments: 4

Patch Set 2 : '' #

Patch Set 3 : '' #

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+104 lines, -15 lines)			Patch
M	chrome/browser/search_engines/template_url.h	View	1 2	4 chunks	+15 lines, -4 lines	0 comments	Download
M	chrome/browser/search_engines/template_url.cc	View		3 chunks	+19 lines, -10 lines	0 comments	Download
M	chrome/browser/search_engines/template_url_unittest.cc	View	1 2	2 chunks	+70 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

sky

LGTM http://codereview.chromium.org/555012/diff/1/2 File chrome/browser/search_engines/template_url_unittest.cc (right): http://codereview.chromium.org/555012/diff/1/2#newcode440 chrome/browser/search_engines/template_url_unittest.cc:440: EXPECT_EQ(L"", parsed_url); nit: L"" -> std::wstring() here and ...

10 years, 11 months ago (2010-01-20 21:37:23 UTC) #2

whywhat

10 years, 11 months ago (2010-01-21 04:59:29 UTC) #3

Will commit as soon as trybots succeed

http://codereview.chromium.org/555012/diff/1/2
File chrome/browser/search_engines/template_url_unittest.cc (right):

http://codereview.chromium.org/555012/diff/1/2#newcode440
chrome/browser/search_engines/template_url_unittest.cc:440: EXPECT_EQ(L"",
parsed_url);
On 2010/01/20 21:37:24, sky wrote:
> nit: L"" -> std::wstring() here and in other places

Done.

http://codereview.chromium.org/555012/diff/1/2#newcode482
chrome/browser/search_engines/template_url_unittest.cc:482: 
On 2010/01/20 21:37:24, sky wrote:
> nit: nuke this line

Done.

Expand Messages | Collapse Messages