Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3316)

Unified Diff: chrome/browser/ui/app_modal_dialogs/js_modal_dialog.h

Issue 5548001: It turns out the Cleanup() method in JsModalDialog is not (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: whoops Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/app_modal_dialogs/js_modal_dialog.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/app_modal_dialogs/js_modal_dialog.h
diff --git a/chrome/browser/ui/app_modal_dialogs/js_modal_dialog.h b/chrome/browser/ui/app_modal_dialogs/js_modal_dialog.h
index 5b36451e57ccb0ad2169be8b2ba6877a8adc4c3d..24c3ccb0b79d4dc9dd5d6a5e1df044f89daaecfc 100644
--- a/chrome/browser/ui/app_modal_dialogs/js_modal_dialog.h
+++ b/chrome/browser/ui/app_modal_dialogs/js_modal_dialog.h
@@ -78,10 +78,6 @@ class JavaScriptAppModalDialog : public AppModalDialog,
bool display_suppress_checkbox() const { return display_suppress_checkbox_; }
bool is_before_unload_dialog() const { return is_before_unload_dialog_; }
- protected:
- // Overridden from AppModalDialog:
- virtual void Cleanup();
-
private:
// Overridden from NotificationObserver:
virtual void Observe(NotificationType type,
@@ -91,6 +87,10 @@ class JavaScriptAppModalDialog : public AppModalDialog,
// Initializes for notifications to listen.
void InitNotifications();
+ // Updates the delegate with the result of the dialog.
+ void UpdateDelegate(bool success, const std::wstring& prompt_text,
Matt Perry 2010/12/03 00:58:53 one more nit: maybe NotifyDelegate would be more a
+ bool suppress_js_messages);
+
NotificationRegistrar registrar_;
// An implementation of the client interface to provide supporting methods
« no previous file with comments | « no previous file | chrome/browser/ui/app_modal_dialogs/js_modal_dialog.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698