chrome/browser/ui/app_modal_dialogs/js_modal_dialog.h - Issue 5548001: It turns out the Cleanup() method in JsModalDialog is not

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/app_modal_dialogs/js_modal_dialog.h

Issue 5548001: It turns out the Cleanup() method in JsModalDialog is not (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 10 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/app_modal_dialogs/js_modal_dialog.h

diff --git a/chrome/browser/ui/app_modal_dialogs/js_modal_dialog.h b/chrome/browser/ui/app_modal_dialogs/js_modal_dialog.h

index 5b36451e57ccb0ad2169be8b2ba6877a8adc4c3d..da0fdcd8a0bd1c80a1a48cafd0b8ab7df507b417 100644

--- a/chrome/browser/ui/app_modal_dialogs/js_modal_dialog.h

+++ b/chrome/browser/ui/app_modal_dialogs/js_modal_dialog.h

@@ -78,10 +78,6 @@ class JavaScriptAppModalDialog : public AppModalDialog,

bool display_suppress_checkbox() const { return display_suppress_checkbox_; }

bool is_before_unload_dialog() const { return is_before_unload_dialog_; }

- protected:

- // Overridden from AppModalDialog:

- virtual void Cleanup();

private:

// Overridden from NotificationObserver:

virtual void Observe(NotificationType type,