Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2301)

Side by Side Diff: src/checks.h

Issue 5545006: Optimized scanner to avoid virtual calls for every character read. (Closed)
Patch Set: Addressed review comments. Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/api.cc ('k') | src/compiler.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2006-2008 the V8 project authors. All rights reserved. 1 // Copyright 2006-2008 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 213 matching lines...) Expand 10 before | Expand all | Expand 10 after
224 #define CHECK_EQ(expected, value) CheckEqualsHelper(__FILE__, __LINE__, \ 224 #define CHECK_EQ(expected, value) CheckEqualsHelper(__FILE__, __LINE__, \
225 #expected, expected, #value, value) 225 #expected, expected, #value, value)
226 226
227 227
228 #define CHECK_NE(unexpected, value) CheckNonEqualsHelper(__FILE__, __LINE__, \ 228 #define CHECK_NE(unexpected, value) CheckNonEqualsHelper(__FILE__, __LINE__, \
229 #unexpected, unexpected, #value, value) 229 #unexpected, unexpected, #value, value)
230 230
231 231
232 #define CHECK_GT(a, b) CHECK((a) > (b)) 232 #define CHECK_GT(a, b) CHECK((a) > (b))
233 #define CHECK_GE(a, b) CHECK((a) >= (b)) 233 #define CHECK_GE(a, b) CHECK((a) >= (b))
234 #define CHECK_LT(a, b) CHECK((a) < (b))
235 #define CHECK_LE(a, b) CHECK((a) <= (b))
234 236
235 237
236 // This is inspired by the static assertion facility in boost. This 238 // This is inspired by the static assertion facility in boost. This
237 // is pretty magical. If it causes you trouble on a platform you may 239 // is pretty magical. If it causes you trouble on a platform you may
238 // find a fix in the boost code. 240 // find a fix in the boost code.
239 template <bool> class StaticAssertion; 241 template <bool> class StaticAssertion;
240 template <> class StaticAssertion<true> { }; 242 template <> class StaticAssertion<true> { };
241 // This macro joins two tokens. If one of the tokens is a macro the 243 // This macro joins two tokens. If one of the tokens is a macro the
242 // helper call causes it to be resolved before joining. 244 // helper call causes it to be resolved before joining.
243 #define SEMI_STATIC_JOIN(a, b) SEMI_STATIC_JOIN_HELPER(a, b) 245 #define SEMI_STATIC_JOIN(a, b) SEMI_STATIC_JOIN_HELPER(a, b)
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
280 // Static asserts has no impact on runtime performance, so they can be 282 // Static asserts has no impact on runtime performance, so they can be
281 // safely enabled in release mode. Moreover, the ((void) 0) expression 283 // safely enabled in release mode. Moreover, the ((void) 0) expression
282 // obeys different syntax rules than typedef's, e.g. it can't appear 284 // obeys different syntax rules than typedef's, e.g. it can't appear
283 // inside class declaration, this leads to inconsistency between debug 285 // inside class declaration, this leads to inconsistency between debug
284 // and release compilation modes behavior. 286 // and release compilation modes behavior.
285 #define STATIC_ASSERT(test) STATIC_CHECK(test) 287 #define STATIC_ASSERT(test) STATIC_CHECK(test)
286 288
287 #define ASSERT_NOT_NULL(p) ASSERT_NE(NULL, p) 289 #define ASSERT_NOT_NULL(p) ASSERT_NE(NULL, p)
288 290
289 #endif // V8_CHECKS_H_ 291 #endif // V8_CHECKS_H_
OLDNEW
« no previous file with comments | « src/api.cc ('k') | src/compiler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698