Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4156)

Unified Diff: chrome/browser/safe_browsing/safe_browsing_database.h

Issue 5544008: Add a browser test for safebrowsing service.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/safe_browsing_database.h
===================================================================
--- chrome/browser/safe_browsing/safe_browsing_database.h (revision 69048)
+++ chrome/browser/safe_browsing/safe_browsing_database.h (working copy)
@@ -24,7 +24,19 @@
class BloomFilter;
class GURL;
class MessageLoop;
+class SafeBrowsingDatabase;
+// Factory for creating SafeBrowsingDatabase. Tests implement this factory
+// to create fake Databases for testing.
+class SafeBrowsingDatabaseFactory {
+ public:
+ SafeBrowsingDatabaseFactory() { }
+ virtual ~SafeBrowsingDatabaseFactory() { }
+ virtual SafeBrowsingDatabase* CreateSafeBrowsingDatabase() = 0;
+ private:
+ DISALLOW_COPY_AND_ASSIGN(SafeBrowsingDatabaseFactory);
+};
+
// Encapsulates the database that stores information about phishing
// and malware sites. There is one on-disk database for all profiles,
// as it doesn't contain user-specific data. This object is not
@@ -34,7 +46,15 @@
class SafeBrowsingDatabase {
public:
// Factory method for obtaining a SafeBrowsingDatabase implementation.
+ // It is not thread safe.
static SafeBrowsingDatabase* Create();
+
+ // Makes the passed |factory| the factory used to instantiate
+ // a SafeBrowsingDatabase. This is used for tests.
+ static void RegisterFactory(SafeBrowsingDatabaseFactory* factory) {
+ factory_ = factory;
+ }
+
virtual ~SafeBrowsingDatabase();
// Initializes the database with the given filename.
@@ -112,6 +132,12 @@
};
static void RecordFailure(FailureType failure_type);
+
+ private:
+ // The factory used to instantiate a SafeBrowsingDatabase object.
+ // Useful for tests, so they can provide their own implementation of
+ // SafeBrowsingDatabase.
+ static SafeBrowsingDatabaseFactory* factory_;
};
class SafeBrowsingDatabaseNew : public SafeBrowsingDatabase {
« no previous file with comments | « chrome/browser/safe_browsing/protocol_manager.cc ('k') | chrome/browser/safe_browsing/safe_browsing_database.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698