Add a browser test for safebrowsing service....

chrome/browser/safe_browsing/safe_browsing_database.h

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_SAFE_BROWSING_SAFE_BROWSING_DATABASE_H_
 #define CHROME_BROWSER_SAFE_BROWSING_SAFE_BROWSING_DATABASE_H_
 #pragma once
 
 #include <set>
 #include <vector>
 
 #include "base/file_path.h"
 #include "base/lock.h"
 #include "base/scoped_ptr.h"
 #include "base/task.h"
 #include "chrome/browser/safe_browsing/safe_browsing_store.h"
 #include "chrome/browser/safe_browsing/safe_browsing_util.h"
 #include "testing/gtest/include/gtest/gtest_prod.h"
 
 namespace base {
   class Time;
 }
 
 class BloomFilter;
 class GURL;
 class MessageLoop;
+class SafeBrowsingDatabase;
+
+// Factory for creating SafeBrowsingDatabase. Tests implement this factory
+// to create fake Databases for testing.
+class SafeBrowsingDatabaseFactory {
+ public:
+  SafeBrowsingDatabaseFactory() { }
+  virtual ~SafeBrowsingDatabaseFactory() { }
+  virtual SafeBrowsingDatabase* CreateSafeBrowsingDatabase() = 0;
+ private:
+  DISALLOW_COPY_AND_ASSIGN(SafeBrowsingDatabaseFactory);
+};
 
 // Encapsulates the database that stores information about phishing
 // and malware sites.  There is one on-disk database for all profiles,
 // as it doesn't contain user-specific data.  This object is not
 // thread-safe, i.e. all its methods should be used on the same thread
 // that it was created on.
 
 class SafeBrowsingDatabase {
  public:
   // Factory method for obtaining a SafeBrowsingDatabase implementation.
   static SafeBrowsingDatabase* Create();
+
+  // Makes the passed |factory| the factory used to instanciate

[Scott Hess - ex-Googler, 2010/12/07 21:22:57]

"instantiate".

+  // a SafeBrowsingDatabase. This is used for tests.
+  static void RegisterFactory(SafeBrowsingDatabaseFactory* factory) {
+    factory_ = factory;
+  }
+
   virtual ~SafeBrowsingDatabase();
 
   // Initializes the database with the given filename.
   virtual void Init(const FilePath& filename) = 0;
 
   // Deletes the current database and creates a new one.
   virtual bool ResetDatabase() = 0;
 
   // Returns false if |url| is not in the database.  If it returns
   // true, then either |matching_list| is the name of the matching
@@ skipping 57 matching lines @@
     FAILURE_DATABASE_FILTER_DELETE,
     FAILURE_DATABASE_STORE_MISSING,
     FAILURE_DATABASE_STORE_DELETE,
 
     // Memory space for histograms is determined by the max.  ALWAYS
     // ADD NEW VALUES BEFORE THIS ONE.
     FAILURE_DATABASE_MAX
   };
 
   static void RecordFailure(FailureType failure_type);
+ private:

[Scott Hess - ex-Googler, 2010/12/07 21:22:57]

Newline between RecordFailure() and private:.

+  // The factory used to instanciate a SafeBrowsingDatabase object.

[Scott Hess - ex-Googler, 2010/12/07 21:22:57]

"instantiate".

+  // Useful for tests, so they can provide their own implementation of
+  // SafeBrowsingDatabase.
+  static SafeBrowsingDatabaseFactory* factory_;
+
 };
 
 class SafeBrowsingDatabaseNew : public SafeBrowsingDatabase {
  public:
   // Create a database on the given store.  Takes ownership of
   // |store|.  This method is temporary for
   // SafeBrowsingDatabase::Create(), do not use it otherwise.
   explicit SafeBrowsingDatabaseNew(SafeBrowsingStore* store);
 
   // Create a database with a default store.
@@ skipping 78 matching lines @@
   // Used to schedule resetting the database because of corruption.
   ScopedRunnableMethodFactory<SafeBrowsingDatabaseNew> reset_factory_;
 
   // Set if corruption is detected during the course of an update.
   // Causes the update functions to fail with no side effects, until
   // the next call to |UpdateStarted()|.
   bool corruption_detected_;
 };
 
 #endif  // CHROME_BROWSER_SAFE_BROWSING_SAFE_BROWSING_DATABASE_H_