Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2699)

Unified Diff: chrome/browser/extensions/extension_install_ui.cc

Issue 5543001: Tests for incognito app install, plus some cleanup. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Use FILE_PATH_LITERAL Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_install_ui.cc
diff --git a/chrome/browser/extensions/extension_install_ui.cc b/chrome/browser/extensions/extension_install_ui.cc
index f0634d33356b668bb919e41972bcc13c239bed70..3f3af1237de2ac93be57588a3b6d49e7d299ac2a 100644
--- a/chrome/browser/extensions/extension_install_ui.cc
+++ b/chrome/browser/extensions/extension_install_ui.cc
@@ -133,10 +133,13 @@ void ExtensionInstallUI::OnInstallSuccess(const Extension* extension,
return;
}
- // Note that browser actions don't appear in incognito mode initially,
- // so be sure to use a normal browser window.
Profile* profile = profile_;
- if (extension->browser_action())
+ // Browser actions don't appear in incognito mode initially,
+ // so be sure to use a normal browser window. The apps panel (which
+ // has a nice animation for the newly installed app) is not available
+ // in incognito mode (until http://crbug.com/63751 is fixed) so we need a
+ // normal browser window for that too.
+ if (extension->browser_action() || extension->is_app())
profile = profile->GetOriginalProfile();
Browser* browser = Browser::GetOrCreateTabbedBrowser(profile);
if (browser->tab_count() == 0)

Powered by Google App Engine
This is Rietveld 408576698