Tests for incognito app install, plus some cleanup.

chrome/browser/extensions/extension_install_ui_browsertest.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_browsertest.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/extensions/theme_installed_infobar_delegate.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/tab_contents/tab_contents.h"
 #include "chrome/browser/ui/browser.h"
@@ skipping 42 matching lines @@
   theme = browser()->profile()->GetTheme();
   ASSERT_TRUE(theme);
   ASSERT_EQ(theme_crx, theme->id());
   ASSERT_TRUE(InstallExtensionWithUI(theme_path, 0));
   theme = browser()->profile()->GetTheme();
   ASSERT_TRUE(theme);
   ASSERT_EQ(theme_crx, theme->id());
   VerifyThemeInfoBarAndUndoInstall();
   ASSERT_EQ(NULL, browser()->profile()->GetTheme());
 }
+
+IN_PROC_BROWSER_TEST_F(ExtensionInstallUIBrowserTest,
+                       AppInstallConfirmation) {
+  int num_tabs = browser()->tab_count();
+
+  FilePath app_path = test_data_dir_.AppendASCII("app.crx");
+  ASSERT_TRUE(InstallExtensionWithUIAutoConfirm(app_path, 1,
+                                                browser()->profile()));
+  EXPECT_EQ(num_tabs + 1, browser()->tab_count());

[Aaron Boodman, 2010/12/14 23:21:44]

Is it also possible to test that the new tab is the NTP URL? (see
chrome/common/url_constants.h - kChromeUINewTabURL)

[Tessa MacDuff, 2010/12/15 00:38:55]

Done.

+}
+
+IN_PROC_BROWSER_TEST_F(ExtensionInstallUIBrowserTest,
+                       AppInstallConfirmation_Incognito) {
+  Profile* incognito_profile = browser()->profile()->GetOffTheRecordProfile();
+  Browser* incognito_browser = Browser::GetOrCreateTabbedBrowser(
+      incognito_profile);
+
+  int num_incognito_tabs = incognito_browser->tab_count();
+  int num_normal_tabs = browser()->tab_count();
+
+  FilePath app_path = test_data_dir_.AppendASCII("app.crx");
+  ASSERT_TRUE(InstallExtensionWithUIAutoConfirm(app_path, 1,
+                                                incognito_profile));
+  EXPECT_EQ(num_incognito_tabs, incognito_browser->tab_count());
+  EXPECT_EQ(num_normal_tabs + 1, browser()->tab_count());
+}