Tests for incognito app install, plus some cleanup.

chrome/browser/extensions/extension_install_ui.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_install_ui.h"
 
 #include <map>
 
 #include "app/l10n_util.h"
 #include "app/resource_bundle.h"
@@ skipping 115 matching lines @@
                                           SkBitmap* icon) {
   extension_ = extension;
   SetIcon(icon);
 
   if (extension->is_theme()) {
     ShowThemeInfoBar(previous_theme_id_, previous_use_system_theme_,
                      extension, profile_);
     return;
   }
 
-  // Note that browser actions don't appear in incognito mode initially,
-  // so be sure to use a normal browser window.
   Profile* profile = profile_;
-  if (extension->browser_action())
+  // Browser actions don't appear in incognito mode initially,
+  // so be sure to use a normal browser window.  The apps panel (which
+  // has a nice animation for the newly installed app) is not available
+  // in incognito mode (until http://crbug.com/63751 is fixed) so we need a
+  // normal browser window for that too.
+  if (extension->browser_action() || extension->is_app())
     profile = profile->GetOriginalProfile();
   Browser* browser = Browser::GetOrCreateTabbedBrowser(profile);
   if (browser->tab_count() == 0)
     browser->AddBlankTab(true);
   browser->window()->Show();
 
   if (extension->GetFullLaunchURL().is_valid()) {
     std::string hash_params = "app-id=";
     hash_params += extension->id();
 
@@ skipping 165 matching lines @@
     TabContents* tab_contents, const Extension* new_theme,
     const std::string& previous_theme_id, bool previous_use_system_theme) {
 #if defined(TOOLKIT_GTK)
   return new GtkThemeInstalledInfoBarDelegate(tab_contents, new_theme,
       previous_theme_id, previous_use_system_theme);
 #else
   return new ThemeInstalledInfoBarDelegate(tab_contents, new_theme,
       previous_theme_id);
 #endif
 }