Issue 554151: [Mac] Reduce jank in the cookie manager by lazily creating child nodes for the UI.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 554151: [Mac] Reduce jank in the cookie manager by lazily creating child nodes for the UI. (Closed)

Created:
10 years, 10 months ago by Robert Sesek

Modified:
9 years, 7 months ago

Reviewers:
John Grabowski

CC:
chromium-reviews_googlegroups.com, John Grabowski, Paweł Hajdan Jr., pam+watch_chromium.org, ben+cc_chromium.org

Visibility:
Public.

Description

[Mac] Reduce jank in the cookie manager by lazily creating child nodes for the UI. Also selects the first cookie node whene expanding an origin node. BUG=33248 TEST=With a lot of cookies in your profile: Chromium-->Preferences-->Under the Hood-->Show cookies... Filter by a domain, expand the domain and the first cookie should be selected. Clear the filter and list should reappear speadily. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=37695

Patch Set 1 #

Total comments: 1

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+24 lines, -13 lines)			Patch
M	chrome/browser/cocoa/cookie_tree_node.h	View	2 chunks	+3 lines, -1 line	0 comments	Download
M	chrome/browser/cocoa/cookie_tree_node.mm	View	3 chunks	+13 lines, -11 lines	1 comment	Download
M	chrome/browser/cocoa/cookies_window_controller.mm	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	chrome/browser/cocoa/cookies_window_controller_unittest.mm	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

John Grabowski

10 years, 10 months ago (2010-02-01 07:52:06 UTC) #2

LGTM

http://codereview.chromium.org/554151/diff/1/3
File chrome/browser/cocoa/cookie_tree_node.mm (right):

http://codereview.chromium.org/554151/diff/1/3#newcode18
chrome/browser/cocoa/cookie_tree_node.mm:18: isLeaf_ = (node->GetChildCount() ==
0);
Not sure why there is a need for a local variable here but if you like it then
it's fine.

Expand Messages | Collapse Messages