Don't pass the "at start" parameter to native RegExp...

Don't pass the "at start" parameter to native RegExp

As the start index is already passed it is easy to calculate the "at start" boolean in generated code. Also as direct entry has been implemented this needs to be done in generated code anyway, and therefore might as well be moved to the generated code for RegExp. The "at start" value is now calcualted as a local variable on the native RegExp frame based on the value of the start index argument.

The x64 version have been tested on both Linux and 64-bit Windows Vista.

For ARM I have tested cctest/test-regexp on ARM hardware, but the rest of the tests have only been run on the ARM simulator.

Committed: http://code.google.com/p/v8/source/detail?r=3709

[Lasse Reichstein, 2010-01-26 10:13:28]

LGTM

http://codereview.chromium.org/554078/diff/4001/5010
File src/x64/regexp-macro-assembler-x64.h (right):

http://codereview.chromium.org/554078/diff/4001/5010#newcode176
src/x64/regexp-macro-assembler-x64.h:176: static const int kAtStart =
kInputStartMinusOne - kPointerSize;
Please add a comment here saying that the valid values of atStart is 0 (false)
and 1 (true).

[Søren Thygesen Gjesse, 2010-01-26 10:33:14]

http://codereview.chromium.org/554078/diff/4001/5010
File src/x64/regexp-macro-assembler-x64.h (right):

http://codereview.chromium.org/554078/diff/4001/5010#newcode176
src/x64/regexp-macro-assembler-x64.h:176: static const int kAtStart =
kInputStartMinusOne - kPointerSize;
On 2010/01/26 10:13:28, Lasse Reichstein wrote:
> Please add a comment here saying that the valid values of atStart is 0 (false)
> and 1 (true).

Updated the documentation in all three *.cc files instead describing the local
variable at start.