Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 554063: Handle some special-case naming for chromiumos-build (Closed)

Created:
10 years, 11 months ago by cjwatson
Modified:
9 years, 7 months ago
Reviewers:
tedbo, Bill Richardson
CC:
chromium-os-reviews_chromium.org
Visibility:
Public.

Description

Handle some special-case naming for chromiumos-build chromiumos-build gets less confused if we refer to the package name e4fsprogs-git rather than the directory name e2fsprogs (which is also a different source package downloadable from Ubuntu). Don't bother trying to build ibus-anthy, ibus-chewing, or ibus-hangul on anything other than i386 for now. They aren't easily cross-buildable and we can live without input methods.

Patch Set 1 #

Total comments: 2

Patch Set 2 : add warning #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -1 line) Patch
M src/scripts/build_platform_packages.sh View 1 1 chunk +18 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
cjwatson
10 years, 11 months ago (2010-01-25 15:31:10 UTC) #1
Bill Richardson
Since this is a temporary hack, let's add some warning so we don't have to ...
10 years, 11 months ago (2010-01-25 16:23:26 UTC) #2
cjwatson
http://codereview.chromium.org/554063/diff/1/2 File src/scripts/build_platform_packages.sh (right): http://codereview.chromium.org/554063/diff/1/2#newcode73 src/scripts/build_platform_packages.sh:73: fi On 2010/01/25 16:23:26, Bill Richardson wrote: > Please ...
10 years, 11 months ago (2010-01-25 16:51:28 UTC) #3
Bill Richardson
10 years, 11 months ago (2010-01-25 17:04:17 UTC) #4
LGTM.

Thanks.

Powered by Google App Engine
This is Rietveld 408576698