Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issue 5540001: Add external extensions to pending map so they always load.... (Closed)

Created:
10 years ago by stevenjb
Modified:
9 years, 7 months ago
CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, pam+watch_chromium.org, ben+cc_chromium.org
Visibility:
Public.

Description

Add external extensions to pending map so they always load. See http://codereview.chromium.org/5492001/ for details. The CL is being merged int 552d early because it addresses a critical issue. BUG=http://code.google.com/p/chromium-os/issues/detail?id=9746 TEST=manual

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -2 lines) Patch
M chrome/browser/extensions/extension_updater.cc View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/extensions/extensions_service.cc View 2 chunks +16 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
stevenjb
Anyone who can take a look at this patch, specifically for the ChromeOS 552d branch, ...
10 years ago (2010-12-02 00:49:10 UTC) #1
zel
LGTM
10 years ago (2010-12-02 00:50:06 UTC) #2
asargent_no_longer_on_chrome
As a quick fix for the branch it seems ok, but I think we might ...
10 years ago (2010-12-02 03:49:37 UTC) #3
Erik does not do reviews
I added you, Aaron and Sam to the bug. I'm really concerned that we've rushed ...
10 years ago (2010-12-02 05:14:58 UTC) #4
stevenjb
Closing this issue and relying on Dmitry, et. al. to ensure that this is fixed ...
10 years ago (2010-12-07 23:07:08 UTC) #5
Dmitry Polukhin
10 years ago (2010-12-08 11:03:49 UTC) #6
I committed my patch to trunk few days ago.

Powered by Google App Engine
This is Rietveld 408576698