Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(581)

Issue 5539003: Remove expectations for 2 tests that do now pass: (Closed)

Created:
10 years ago by Nico
Modified:
9 years, 7 months ago
Reviewers:
Julie Parent
CC:
chromium-reviews, darin-cc_chromium.org, pam+watch_chromium.org, ojan
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M webkit/tools/layout_tests/test_expectations.txt View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Nico
10 years ago (2010-12-02 18:18:54 UTC) #1
Julie Parent
10 years ago (2010-12-02 18:20:49 UTC) #2
LGTM

I'm glad the mystery has been explained!

On Thu, Dec 2, 2010 at 10:18 AM, <thakis@chromium.org> wrote:

> Reviewers: Julie Parent,
>
> Description:
> Remove expectations for 2 tests that do now pass:
>
>
>
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=svg...
>
>
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=tab...
>
> Fixed upstream here:
> http://trac.webkit.org/changeset/73089
>
> BUG=64395,64394
> TEST=webkit tests stay green
>
> Please review this at http://codereview.chromium.org/5539003/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files:
>  M webkit/tools/layout_tests/test_expectations.txt
>
>
> Index: webkit/tools/layout_tests/test_expectations.txt
> diff --git a/webkit/tools/layout_tests/test_expectations.txt
> b/webkit/tools/layout_tests/test_expectations.txt
> index
>
b0bb7c4601997b510c985ad4f2183cebaf7efa96..5b179ee335b07ae8dc5d8391d3e89f69f2662f24
> 100644
> --- a/webkit/tools/layout_tests/test_expectations.txt
> +++ b/webkit/tools/layout_tests/test_expectations.txt
> @@ -12,10 +12,6 @@ BUG_JPARENT LINUX :
> fast/dom/HTMLHeadElement/head-check.html = CRASH PASS
>  // (72440; 72514] range
>  BUG_ANTON LINUX : fast/ruby/nested-ruby.html = CRASH PASS IMAGE
>
> -// Rebaseline tool wasn't working for these tests.
> -BUG64394 MAC : svg/W3C-SVG-1.1/struct-image-10-t.svg = IMAGE
> -BUG64395 MAC : tables/mozilla/bugs/bug14929.html = IMAGE
> -
>  BUG_LOISLO WIN RELEASE : http/tests/appcache/online-whitelist.html = TEXT
>
>  // This test failed on mac because this line was removed by webkit
>
>
>

Powered by Google App Engine
This is Rietveld 408576698