Issue 5539001: Remove all the swap() stuff in the PPAPI C++ wrappers....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5539001: Remove all the swap() stuff in the PPAPI C++ wrappers.... (Closed)

Created:
10 years ago by brettw

Modified:
9 years, 7 months ago

Reviewers:
viettrungluu

CC:
chromium-reviews

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Remove all the swap() stuff in the PPAPI C++ wrappers. Basically all of them are trivial and you can use the std::swap just as efficiently. Since this is unnecessary, we can reduce the complexity a bit. TEST=none BUG=54441 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=68028

Patch Set 1 #

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+26 lines, -109 lines)			Patch
M	ppapi/cpp/dev/buffer_dev.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	ppapi/cpp/dev/buffer_dev.cc	View	1 chunk	+3 lines, -8 lines	0 comments	Download
M	ppapi/cpp/dev/directory_entry_dev.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	ppapi/cpp/dev/directory_entry_dev.cc	View	1 chunk	+5 lines, -7 lines	0 comments	Download
M	ppapi/cpp/dev/directory_reader_dev.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	ppapi/cpp/dev/directory_reader_dev.cc	View	1 chunk	+1 line, -6 lines	0 comments	Download
M	ppapi/cpp/dev/file_chooser_dev.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	ppapi/cpp/dev/file_chooser_dev.cc	View	1 chunk	+1 line, -5 lines	0 comments	Download
M	ppapi/cpp/dev/file_io_dev.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	ppapi/cpp/dev/file_io_dev.cc	View	1 chunk	+1 line, -6 lines	0 comments	Download
M	ppapi/cpp/dev/file_ref_dev.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	ppapi/cpp/dev/file_ref_dev.cc	View	1 chunk	+1 line, -6 lines	0 comments	Download
M	ppapi/cpp/dev/font_dev.h	View	3 chunks	+2 lines, -5 lines	0 comments	Download
M	ppapi/cpp/dev/font_dev.cc	View	3 chunks	+9 lines, -39 lines	0 comments	Download
M	ppapi/cpp/dev/scrollbar_dev.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	ppapi/cpp/dev/scrollbar_dev.cc	View	1 chunk	+1 line, -6 lines	0 comments	Download
M	ppapi/cpp/dev/video_decoder_dev.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	ppapi/cpp/dev/video_decoder_dev.cc	View	1 chunk	+1 line, -6 lines	0 comments	Download
M	ppapi/cpp/dev/widget_dev.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	ppapi/cpp/dev/widget_dev.cc	View	1 chunk	+1 line, -6 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm (assuming everything builds)

Expand Messages | Collapse Messages