Issue 5537001: New Heap Profiler: add API method for finding a graph node by id.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5537001: New Heap Profiler: add API method for finding a graph node by id. (Closed)

Created:
10 years ago by mnaganov (inactive)

Modified:
9 years, 7 months ago

Reviewers:
Søren Thygesen Gjesse

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

New Heap Profiler: add API method for finding a graph node by id. TEST=cctest/test-heap-profiler/HeapSnapshotGetNodeById Committed: http://code.google.com/p/v8/source/detail?r=5914

Patch Set 1 #

Total comments: 2

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+51 lines, -0 lines)			Patch
M	include/v8-profiler.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/api.cc	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	src/profile-generator.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/profile-generator.cc	View	1 chunk	+22 lines, -0 lines	2 comments	Download
M	test/cctest/test-heap-profiler.cc	View	1 chunk	+18 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Søren Thygesen Gjesse

LGTM http://codereview.chromium.org/5537001/diff/1/src/profile-generator.cc File src/profile-generator.cc (right): http://codereview.chromium.org/5537001/diff/1/src/profile-generator.cc#newcode1556 src/profile-generator.cc:1556: int mid = ((unsigned int)low + (unsigned int)high) ...

10 years ago (2010-12-02 07:37:15 UTC) #2

mnaganov (inactive)

10 years ago (2010-12-02 15:38:24 UTC) #3

http://codereview.chromium.org/5537001/diff/1/src/profile-generator.cc
File src/profile-generator.cc (right):

http://codereview.chromium.org/5537001/diff/1/src/profile-generator.cc#newcod...
src/profile-generator.cc:1556: int mid = ((unsigned int)low + (unsigned
int)high) >> 1;
On 2010/12/02 07:37:15, Søren Gjesse wrote:
> No C-style casts please.

Done.

Expand Messages | Collapse Messages