Use latest format config file.

Use latest format config file.

Change-Id: I21f15ea3d6c1fedd977eb254fcb767dd5fd2f4a1

BUG=chromium-os:781
TEST=manual, as before

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=a4a639e

[scottz, 2010-12-09 01:47:24]

http://codereview.chromium.org/5535010/diff/1/user_tools/linux/recovery.sh
File user_tools/linux/recovery.sh (right):

http://codereview.chromium.org/5535010/diff/1/user_tools/linux/recovery.sh#ne...
user_tools/linux/recovery.sh:116: external='cat cut dd grep ls mkdir mount
readlink sed sync umount unzip wc'
md5sum openssl sha1sum

I assume you leave wget/curl out since you try both.

http://codereview.chromium.org/5535010/diff/1/user_tools/linux/recovery.sh#ne...
user_tools/linux/recovery.sh:165: # a Mac other than by having this executable?
uname == "Darwin" will tell you you are on a mac.

http://codereview.chromium.org/5535010/diff/1/user_tools/linux/recovery.sh#ne...
user_tools/linux/recovery.sh:750: echo >> "$config"
Is there a reason to not make this be part of the format I am generating?

[Bill Richardson, 2010-12-09 17:34:29]

I responded to your comments. Do you think it's worth explicitly checking that
uname = Darwin before using diskutil?

http://codereview.chromium.org/5535010/diff/1/user_tools/linux/recovery.sh
File user_tools/linux/recovery.sh (right):

http://codereview.chromium.org/5535010/diff/1/user_tools/linux/recovery.sh#ne...
user_tools/linux/recovery.sh:116: external='cat cut dd grep ls mkdir mount
readlink sed sync umount unzip wc'
Yes, just below.

http://codereview.chromium.org/5535010/diff/1/user_tools/linux/recovery.sh#ne...
user_tools/linux/recovery.sh:165: # a Mac other than by having this executable?
Okay. I'm not sure it matters, though. If we've got diskutil, we should probably
just use it, right?

http://codereview.chromium.org/5535010/diff/1/user_tools/linux/recovery.sh#ne...
user_tools/linux/recovery.sh:750: echo >> "$config"
No. The first example didn't have it, and here at Google we tend to frown on
blank lines at the end of files. This just makes my parsing simpler. I don't
know about the others.

[scottz, 2010-12-09 18:04:27]

LGTM

http://codereview.chromium.org/5535010/diff/1/user_tools/linux/recovery.sh
File user_tools/linux/recovery.sh (right):

http://codereview.chromium.org/5535010/diff/1/user_tools/linux/recovery.sh#ne...
user_tools/linux/recovery.sh:116: external='cat cut dd grep ls mkdir mount
readlink sed sync umount unzip wc'
Ahh I missed that :) 

On 2010/12/09 17:34:29, Bill Richardson wrote:
> Yes, just below.

http://codereview.chromium.org/5535010/diff/1/user_tools/linux/recovery.sh#ne...
user_tools/linux/recovery.sh:165: # a Mac other than by having this executable?
Sure we can assume that, I was just answering your fixme :) if you are fine with
how it works you might as well remove this comment. 

On 2010/12/09 17:34:29, Bill Richardson wrote:
> Okay. I'm not sure it matters, though. If we've got diskutil, we should
probably
> just use it, right?