Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Issue 5535007: ibus-chewing: Support IBus-1.4 API. (Closed)

Created:
10 years ago by Yusuke Sato
Modified:
9 years, 7 months ago
Reviewers:
Peng
CC:
chromium-os-reviews_chromium.org, Zachary Kuznia, satorux1
Visibility:
Public.

Description

ibus-chewing: Support IBus-1.4 API. Manually merged a necessary part of the upstream change: https://github.com/definite/ibus-chewing/commit/d9009bf05d9d8b600936beb3c3b0ecfc84a1075a I would rather not update ibus-chewing to tot of the upstream repository since it might make the engine unstable again. BUG=chromium-os:9687 TEST=ran 'emerge-x86-generic ibus-chewing' Change-Id: Iaa7b7c79eca727b51da2293c948b316efbb788a6 Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=7a30fc7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -5 lines) Patch
M src/IBusChewingEngine.gob View 3 chunks +3 lines, -3 lines 0 comments Download
M src/IBusChewingEngine-def.c View 1 chunk +78 lines, -0 lines 0 comments Download
M src/main.c View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Yusuke Sato
10 years ago (2010-12-06 19:10:01 UTC) #1
Peng
10 years ago (2010-12-07 03:26:10 UTC) #2
On 2010/12/06 19:10:01, Yusuke Sato wrote:

LGTM

Powered by Google App Engine
This is Rietveld 408576698