Issue 5535003: scons: excise more scons references from the code base

Issue 5535003: scons: excise more scons references from the code base (Closed)

Created:
10 years ago by Evan Martin

Modified:
9 years, 7 months ago

Reviewers:
tony, _com_google_glider, Timur Iskhodzhanov, Elliot Glaysher

CC:
chromium-reviews, Alexander Potapenko, amit, jam, apatrick_chromium, pam+watch_chromium.org, brettw-cc_chromium.org, darin-cc_chromium.org, stuartmorgan+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

scons: excise more scons references from the code base I got to undo some hacks, too! TEST=compiles Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=68119

Patch Set 1 #

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+12 lines, -188 lines)			Patch
M	base/base_paths_linux.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	base/debug/stack_trace_posix.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	breakpad/breakpad.gyp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	build/common.gypi	View	3 chunks	+0 lines, -74 lines	0 comments	Download
M	build/linux/system.gyp	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome_frame/crash_reporting/crash_reporting.gyp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	gpu/gpu.gyp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ipc/ipc_message_impl_macros.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ipc/ipc_message_macros.h	View	1 chunk	+1 line, -1 line	0 comments	Download
D	site_scons/site_tools/chromium_builders.py	View	1 chunk	+0 lines, -40 lines	0 comments	Download
M	testing/gmock.gyp	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	testing/gtest.gyp	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	tools/code_coverage/coverage_posix.py	View	1 chunk	+1 line, -1 line	0 comments	Download
D	tools/data_pack/scons.py	View	1 chunk	+0 lines, -54 lines	0 comments	Download
M	tools/export_tarball/export_tarball.py	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	tools/heapcheck/chrome_tests.py	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	tools/valgrind/chrome_tests.py	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	tools/valgrind/valgrind.sh	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

_com_google_glider

On 2010/12/02 22:51:23, Elliot Glaysher wrote: > Joy. LG. LG for the Valgrind/Heapcheck part

10 years ago (2010-12-03 07:57:24 UTC) #3

Timur Iskhodzhanov

Please note that "sconsbuild" is still found in the trunk/tools/build in a few places, including ...

10 years ago (2010-12-03 11:19:24 UTC) #4

Timur Iskhodzhanov

10 years ago (2010-12-03 11:20:27 UTC) #5

Though your current change doesn't break anything in Valgrind.

On 2010/12/03 11:19:24, Timur Iskhodzhanov wrote:
> Please note that "sconsbuild" is still found in the trunk/tools/build in a few
> places, including Valgrind --build_dir parameter

Expand Messages | Collapse Messages