Issue 5535002: Decouple killbit testing from external extension providers

Issue 5535002: Decouple killbit testing from external extension providers (Closed)

Created:
10 years ago by gfeher

Modified:
9 years, 7 months ago

Reviewers:
Aaron Boodman, Sam Kerner (Chrome), Erik does not do reviews

CC:
chromium-reviews, pam+watch_chromium.org, ben+cc_chromium.org, Paweł Hajdan Jr., Dmitry Polukhin, Erik does not do reviews, Aaron Boodman

Base URL:
http://git.chromium.org/git/chromium.git@trunk

Visibility:
Public.

Description

Decouple killbit testing from external extension providers Don't test the killbit in each ExternalExtensionProvider, but test it in ExternalExtensionsService. BUG=65107 TEST=ExtensionManagementTest.ExternalUpdate Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=68348

Patch Set 1 : " #

Patch Set 2 : improve tests #

Patch Set 3 : fix #

Patch Set 4 : improve comments #

Total comments: 4

Patch Set 5 : improve tests #

Patch Set 6 : " #

Patch Set 7 : update #

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+91 lines, -92 lines)			Patch
M	chrome/browser/extensions/extension_management_browsertest.cc	View	1 2 3 4 5	1 chunk	+17 lines, -9 lines	0 comments	Download
M	chrome/browser/extensions/extension_prefs.h	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/extensions/extension_prefs.cc	View	1 2 3 4 5 6	1 chunk	+7 lines, -26 lines	0 comments	Download
M	chrome/browser/extensions/extensions_service.h	View	1 2 3 4 5 6	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/extensions/extensions_service.cc	View	1 2 3 4 5 6	6 chunks	+7 lines, -10 lines	0 comments	Download
M	chrome/browser/extensions/extensions_service_unittest.cc	View	1 2 3 4 5 6	6 chunks	+51 lines, -19 lines	0 comments	Download
M	chrome/browser/extensions/external_extension_provider.h	View		2 chunks	+1 line, -5 lines	0 comments	Download
M	chrome/browser/extensions/external_policy_extension_provider_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/external_registry_extension_provider_win.h	View		2 chunks	+1 line, -5 lines	0 comments	Download
M	chrome/browser/extensions/external_registry_extension_provider_win.cc	View		2 chunks	+1 line, -5 lines	0 comments	Download
M	chrome/browser/extensions/stateful_external_extension_provider.h	View		2 chunks	+1 line, -5 lines	0 comments	Download
M	chrome/browser/extensions/stateful_external_extension_provider.cc	View		1 chunk	+1 line, -4 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

gfeher

My basic idea is that this cleanup would make it easier to move the providers ...

10 years ago (2010-12-03 14:18:05 UTC) #2

Erik does not do reviews

Overall I really like this cleanup. One thing that seems missing though is that there ...

10 years ago (2010-12-03 17:15:16 UTC) #3

gfeher

I've added more tests. http://codereview.chromium.org/5535002/diff/19001/chrome/browser/extensions/extension_management_browsertest.cc File chrome/browser/extensions/extension_management_browsertest.cc (right): http://codereview.chromium.org/5535002/diff/19001/chrome/browser/extensions/extension_management_browsertest.cc#newcode300 chrome/browser/extensions/extension_management_browsertest.cc:300: // bacuse of the killbit. ...

10 years ago (2010-12-03 21:10:09 UTC) #4

Aaron Boodman

I like this change too. When you do the other refactoring, can you try and ...

10 years ago (2010-12-03 21:50:26 UTC) #5

gfeher

10 years ago (2010-12-06 16:21:26 UTC) #8

http://codereview.chromium.org/5535002/diff/19001/chrome/browser/extensions/e...
File chrome/browser/extensions/extension_prefs.cc (right):

http://codereview.chromium.org/5535002/diff/19001/chrome/browser/extensions/e...
chrome/browser/extensions/extension_prefs.cc:620: int state;
On 2010/12/03 21:50:27, Aaron Boodman wrote:
> please initialize primitives

Done.

Expand Messages | Collapse Messages