Issue 553166: Simplify submitting try jobs directly from rietveld.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 553166: Simplify submitting try jobs directly from rietveld. (Closed)

Created:
10 years, 10 months ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
Mohamed Mansour

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Simplify submitting try jobs directly from rietveld. trychange.py -R <review_url> is sufficient for try jobs when in a checkout directory. TEST=none BUG=none

Patch Set 1 #

Total comments: 1

Patch Set 2 : simplification #

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -7 lines)			Patch
	M	trychange.py	View	1	4 chunks	+27 lines, -7 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mohamed Mansour

10 years, 10 months ago (2010-01-30 05:39:44 UTC) #2

Some comment, do what you please.

http://codereview.chromium.org/553166/diff/1/2
File trychange.py (right):

http://codereview.chromium.org/553166/diff/1/2#newcode581
trychange.py:581: options.rietveld_url = re.match(r'^(.*)/\d+$',
Couldn't you just do:
 match = re.match(r'^(.*)/(\d+)$', options.rietveld_url)

options.issue = int(match.group(2))
options.rietveld_url = match.group(1)

Expand Messages | Collapse Messages