Issue 553142: Provide an option to allow custom/local setup control file.

Issue 553142: Provide an option to allow custom/local setup control file. (Closed)

Created:
10 years, 11 months ago by petkov

Modified:
9 years, 7 months ago

Reviewers:
ericli

CC:
chromium-os-reviews_chromium.org

Visibility:
Public.

Description

Provide an option to allow custom/local setup control file.

Patch Set 2 : Fix line length and wording. #

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -2 lines)			Patch
	M	src/scripts/build_autotest.sh	View	1	3 chunks	+8 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

ericli

http://codereview.chromium.org/553142/diff/1/2 File src/scripts/build_autotest.sh (right): http://codereview.chromium.org/553142/diff/1/2#newcode24 src/scripts/build_autotest.sh:24: "Setup control file -- location relative to the destination ...

10 years, 11 months ago (2010-01-28 22:59:09 UTC) #2

petkov

10 years, 11 months ago (2010-01-28 23:06:01 UTC) #4

ericli

10 years, 11 months ago (2010-01-28 23:08:53 UTC) #5

LGTM++

On 2010/01/28 23:06:01, petkov wrote:
> http://codereview.chromium.org/553142/diff/1/2
> File src/scripts/build_autotest.sh (right):
> 
> http://codereview.chromium.org/553142/diff/1/2#newcode24
> src/scripts/build_autotest.sh:24: "Setup control file -- location relative to
> the destination autotest directory" c
> On 2010/01/28 22:59:09, ericli wrote:
> > 80 char.
> 
> Done.
> 
> http://codereview.chromium.org/553142/diff/1/2#newcode40
> src/scripts/build_autotest.sh:40: echo "Installing Autotest using
> ${FLAGS_control}... "
> On 2010/01/28 22:59:09, ericli wrote:
> > Could you change the word to "Building"?
> 
> Done -- added a separate progress echo before starting the setup step.

Expand Messages | Collapse Messages