Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(413)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 553128: Adds autox deps configuration and adds setup to AutoLogin (Closed)

Created:
10 years, 11 months ago by sosa
Modified:
9 years, 6 months ago
Reviewers:
petkov, seano
CC:
chromium-os-reviews_googlegroups.com
Visibility:
Public.

Description

Adds autox deps configuration and adds setup to AutoLogin

Patch Set 1 #

Patch Set 2 : Fixes some nits #

Patch Set 3 : Whitespace nit #

Total comments: 5

Patch Set 4 : Adds make_pkg to deps #

Total comments: 1

Patch Set 5 : Fix trailing whitespace #

Patch Set 6 : Fixes to nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -13 lines) Patch
A client/deps/autox/README View 2 3 4 5 1 chunk +8 lines, -0 lines 0 comments Download
A client/deps/autox/autox.py View 1 2 3 4 1 chunk +39 lines, -0 lines 0 comments Download
A client/deps/autox/common.py View 1 2 3 4 5 1 chunk +12 lines, -0 lines 0 comments Download
A client/deps/autox/control View 1 2 3 4 5 1 chunk +5 lines, -0 lines 0 comments Download
M client/site_tests/setup/control View 1 chunk +1 line, -0 lines 0 comments Download
M client/site_tests/system_AutoLogin/control View 1 chunk +1 line, -2 lines 0 comments Download
M client/site_tests/system_AutoLogin/system_AutoLogin.py View 1 2 3 4 5 1 chunk +21 lines, -11 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
sosa
Adds autox to client/deps
10 years, 11 months ago (2010-01-27 22:52:23 UTC) #1
sosa
Actually, Darin could take a look at this as well
10 years, 11 months ago (2010-01-27 22:59:57 UTC) #2
petkov
10 years, 11 months ago (2010-01-27 23:53:26 UTC) #3 
A bunch of nits, LGTM otherwise.

http://codereview.chromium.org/553128/diff/2001/2002
File client/deps/autox/README (right):

http://codereview.chromium.org/553128/diff/2001/2002#newcode1
client/deps/autox/README:1: This deps brings install ChromeOS autox into an
image.  Tests that depend
brings or install. Copyright?

http://codereview.chromium.org/553128/diff/2001/2003
File client/deps/autox/autox.py (right):

http://codereview.chromium.org/553128/diff/2001/2003#newcode15
client/deps/autox/autox.py:15: # arm vs. x86
The target architecture should be an option to ./build_autotest.sh (nothing to
do with this review).

http://codereview.chromium.org/553128/diff/2001/2003#newcode32
client/deps/autox/autox.py:32: utils.update_version(pwd+'/src', False, version,
setup, pwd)
space around +

http://codereview.chromium.org/553128/diff/2001/2004
File client/deps/autox/common.py (right):

http://codereview.chromium.org/553128/diff/2001/2004#newcode1
client/deps/autox/common.py:1: import os, sys
Copyright?

http://codereview.chromium.org/553128/diff/2001/2005
File client/deps/autox/control (right):

http://codereview.chromium.org/553128/diff/2001/2005#newcode1
client/deps/autox/control:1: job.setup_dep(['autox'])
Copyright?

http://codereview.chromium.org/553128/diff/4001/5007
File client/site_tests/system_AutoLogin/system_AutoLogin.py (right):

http://codereview.chromium.org/553128/diff/4001/5007#newcode27
client/site_tests/system_AutoLogin/system_AutoLogin.py:27: 'export DISPLAY=:0.0
&& export XAUTHORITY=/home/chronos/.Xauthority'
I think you can just do:
DISPLAY=:0.0 XAUTHORITY=/home/chronos/.Xauthority <cmd>

Powered by Google App Engine
This is Rietveld 408576698