Spellchecker: fix render view auto-suggest context menu items...

Spellchecker: fix render view auto-suggest context menu items

BUG=28652
TEST=see bug


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=37160

[Evan Stade, 2010-01-26 22:28:35]

in r32561 I did

-  // Fill in the dictionary suggestions if required.
-  if (!params.misspelled_word.empty() &&
-      spellchecker_ != NULL && params.spellcheck_enabled) {
-    int misspell_location, misspell_length;
-    bool is_misspelled = !spellchecker_->SpellCheckWord(
-        params.misspelled_word.c_str(),
-        static_cast<int>(params.misspelled_word.length()), 0,
-        &misspell_location, &misspell_length,
-        &params.dictionary_suggestions);
-
-    // If not misspelled, make the misspelled_word param empty.
-    if (!is_misspelled)
-      params.misspelled_word.clear();
-  }

and

+  ContextMenuParams params = ContextMenuParams(data);
+  if (!params.misspelled_word.empty() && RenderThread::current()) {
+    int misspelled_offset, misspelled_length;
+    bool misspelled = RenderThread::current()->spellchecker()->SpellCheckWord(
+          params.misspelled_word.c_str(), params.misspelled_word.size(),
+          document_tag_,
+          &misspelled_offset, &misspelled_length,
+          &params.dictionary_suggestions);
+    if (!misspelled)
+      params.misspelled_word.clear();
+  }

note the lack of ! before SpellCheckWord()

[Evan Martin, 2010-01-26 22:36:00]

LGTM

http://codereview.chromium.org/553103/diff/1/2
File chrome/renderer/render_view.cc (right):

http://codereview.chromium.org/553103/diff/1/2#newcode1711
chrome/renderer/render_view.cc:1711: bool spelled_right =
RenderThread::current()->spellchecker()->SpellCheckWord(
80

[Evan Martin, 2010-01-27 18:41:08]

prolly wanna cherry-pick this to beta branch

[Evan Stade, 2010-01-27 19:51:33]

On 2010/01/27 18:41:08, Evan Martin wrote:
> prolly wanna cherry-pick this to beta branch

merged to 302; this bug isn't in 249

[Evan Stade, 2010-01-27 20:08:24]

merged to 306 as well