Add ability to push to subset of overlays we rev.

Add ability to push to subset of overlays we rev.

We also fix some of the configs for existing configurations.

Change-Id: I34baa9664ff9e91268c8bac976ab2ab0aee51bfb

BUG=chromium-os:9714
TEST=Running now with cbuildbot x86-generic-pre-flight-queue.

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=55430be

[sosa, 2010-12-02 01:28:53]

I might have my config logic wrong for the private bin's.  It seems we might
want to *push* for the prebuilts but NOT for the rev's for them?

[David James, 2010-12-02 02:06:59]

http://codereview.chromium.org/5531002/diff/1/bin/cbuildbot.py
File bin/cbuildbot.py (left):

http://codereview.chromium.org/5531002/diff/1/bin/cbuildbot.py#oldcode646
bin/cbuildbot.py:646: assert ':' not in path, 'Overlay must not contain colons:
%s' % path
Thanks for cleaning this up -- it wasn't terribly useful.

http://codereview.chromium.org/5531002/diff/1/bin/cbuildbot.py
File bin/cbuildbot.py (right):

http://codereview.chromium.org/5531002/diff/1/bin/cbuildbot.py#newcode630
bin/cbuildbot.py:630: assert set(push_overlays).issubset(set(rev_overlays))
Maybe we should also check that push_overlays must be empty if the bot is not a
master bot.

http://codereview.chromium.org/5531002/diff/1/bin/cbuildbot.py#newcode702
bin/cbuildbot.py:702: _UploadPrebuilts(buildroot, board, rev_overlays,
_UploadPrebuilts expects a string for the third argument, not a list.  I guess
it should be buildconfig['rev_overlays']

http://codereview.chromium.org/5531002/diff/1/bin/cbuildbot_config.py
File bin/cbuildbot_config.py (right):

http://codereview.chromium.org/5531002/diff/1/bin/cbuildbot_config.py#newcode23
bin/cbuildbot_config.py:23: 'public', 'private' or 'both'. There should only be
one master bot
Indentation looks off here. Same below.

The comment about master bots belongs under push_overlays. 

Should we say that push_overlays must be None if the builder is not a master
bot?

[sosa, 2010-12-02 21:47:49]

PTAL

http://codereview.chromium.org/5531002/diff/1/bin/cbuildbot.py
File bin/cbuildbot.py (right):

http://codereview.chromium.org/5531002/diff/1/bin/cbuildbot.py#newcode630
bin/cbuildbot.py:630: assert set(push_overlays).issubset(set(rev_overlays))
On 2010/12/02 02:06:59, David James wrote:
> Maybe we should also check that push_overlays must be empty if the bot is not
a
> master bot.

Done.

http://codereview.chromium.org/5531002/diff/1/bin/cbuildbot.py#newcode702
bin/cbuildbot.py:702: _UploadPrebuilts(buildroot, board, rev_overlays,
On 2010/12/02 02:06:59, David James wrote:
> _UploadPrebuilts expects a string for the third argument, not a list.  I guess
> it should be buildconfig['rev_overlays']

Done.

http://codereview.chromium.org/5531002/diff/1/bin/cbuildbot_config.py
File bin/cbuildbot_config.py (right):

http://codereview.chromium.org/5531002/diff/1/bin/cbuildbot_config.py#newcode23
bin/cbuildbot_config.py:23: 'public', 'private' or 'both'. There should only be
one master bot
On 2010/12/02 02:06:59, David James wrote:
> Indentation looks off here. Same below.
> 
> The comment about master bots belongs under push_overlays. 
> 
> Should we say that push_overlays must be None if the builder is not a master
> bot?

Done.

[davidjames, 2010-12-02 21:51:31]

LGTM