Issue 553084: re-try r37061 with fix for browser tests...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 553084: re-try r37061 with fix for browser tests... (Closed)

Created:
10 years, 11 months ago by Evan Stade

Modified:
9 years, 6 months ago

Reviewers:
Finnur, jorlow, Amanda Walker

CC:
chromium-reviews, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

re-try r37061 with fix for browser tests ---------------------------------------- Views: use ExtensionToolbarModel for ordering of browser action buttons. This doesn't implement drag and drop reording, but the order is stored on shutdown and restored on startup. BUG=26990 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=37302

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+109 lines, -117 lines)			Patch
	M	chrome/browser/views/browser_actions_container.h	View	1	4 chunks	+9 lines, -8 lines	0 comments	Download
	M	chrome/browser/views/browser_actions_container.cc	View	1	6 chunks	+100 lines, -109 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Evan Stade

sorry for all the trouble http://codereview.chromium.org/553084/diff/1/3 File chrome/browser/views/browser_actions_container.cc (right): http://codereview.chromium.org/553084/diff/1/3#newcode312 chrome/browser/views/browser_actions_container.cc:312: model_->RemoveObserver(this); this was the ...

10 years, 11 months ago (2010-01-26 20:30:58 UTC) #1

LGTM

Expand Messages | Collapse Messages