Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(768)

Issue 553066: Rename chromeos-microbenchmark package to libchromeos-microbenchmark-dev (Closed)

Created:
10 years, 11 months ago by cjwatson
Modified:
9 years, 7 months ago
Reviewers:
Will Drewry
CC:
chromium-os-reviews_chromium.org
Visibility:
Public.

Description

Rename chromeos-microbenchmark package to libchromeos-microbenchmark-dev This package only contains a header file and a static library, so libfoo-dev naming is more conventional, and it lets chromiumos-build know that it can cross-convert the resulting package and install it to satisfy future build-dependencies without having to add a special case.

Patch Set 1 #

Total comments: 2

Patch Set 2 : smaller change to make_pkg.sh #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M src/platform/microbenchmark/debian/control View 1 chunk +3 lines, -1 line 0 comments Download
M src/platform/microbenchmark/make_pkg.sh View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/platform/minijail/debian/control View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
cjwatson
10 years, 11 months ago (2010-01-25 10:36:04 UTC) #1
Will Drewry
LGTM functionally, but I don't know why there's so much code duplication in the make_pkg.sh ...
10 years, 11 months ago (2010-01-25 14:53:17 UTC) #2
cjwatson
I'm in the process of obsoleting the entire family of make_pkg.sh functions; once we finally ...
10 years, 11 months ago (2010-01-25 14:59:27 UTC) #3
cjwatson
Updated; please have another look?
10 years, 11 months ago (2010-01-25 15:03:03 UTC) #4
Will Drewry
10 years, 11 months ago (2010-01-25 15:09:43 UTC) #5
LGTM

I wasn't clear which part of the common scripts were surviving or not so this is
definitely good for now (or even the duped code).

thanks!

Powered by Google App Engine
This is Rietveld 408576698