Inline smi code in count operations in the full code generator.

Inline smi code in count operations in the full code generator.

We now test for a smi before calling ToNumber and inline
the smi increment/decrement for ++ and --. There only a small
increase in code size but loops in top-level code are
becoming much faster as a result.


Committed: http://code.google.com/p/v8/source/detail?r=3681

[fschneider, 2010-01-22 13:47:30]

Nothing new here for ia-32 and x64. This changelist includes only the changes to
CountOperation in the full codegenerator. I added the ARM code for the
CountOperation.

[Erik Corry, 2010-01-22 13:56:43]

LGTM

http://codereview.chromium.org/553056/diff/1/4
File src/arm/full-codegen-arm.cc (right):

http://codereview.chromium.org/553056/diff/1/4#newcode1443
src/arm/full-codegen-arm.cc:1443: __ add(r0, r0, Operand(r1));
Small immediates can be added and substracted in the instruction.  Then we only
need to load r1 on the slow path.

[fschneider, 2010-01-22 14:07:42]

http://codereview.chromium.org/553056/diff/1/4
File src/arm/full-codegen-arm.cc (right):

http://codereview.chromium.org/553056/diff/1/4#newcode1443
src/arm/full-codegen-arm.cc:1443: __ add(r0, r0, Operand(r1));
On 2010/01/22 13:56:43, Erik Corry wrote:
> Small immediates can be added and substracted in the instruction.  Then we
only
> need to load r1 on the slow path.

Done.